feat: account upgrade confirmation #30347

matthewwalsh0 · 2025-02-15T01:44:54Z

Description

Update the transaction confirmation to handle account upgrades via EIP-7702.

Specifically:

Add TransactionAccountDetails component.
Show new UpgradeCancelModal on Cancel to provide alternate cancel buttons.
Add Acknowledge component with required checkbox in order to Confirm transaction.
Add accountUpgradeDisabledChains to PreferencesController to persist if user rejects upgrade.
Check preference in getCapabilities and processSendCalls middleware hooks.

Related issues

Fixes: #4214

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-02-19T22:18:17Z

Builds ready [3991b93]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1602 ± 44 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	360	1826	1548	289	139
		domContentLoaded	1438	1810	1579	91	44
		load	1449	1824	1602	92	44
		domInteractive	25	68	33	12	6
		backgroundConnect	10	65	23	15	7
		firstReactRender	14	69	33	23	11
		getState	4	58	13	15	7
		initialActions	0	1	0	0	0
		loadScripts	1057	1397	1189	84	40
		setupStore	7	49	11	9	4
		uiStartup	1703	2571	1869	181	87

metamaskbot · 2025-02-20T01:59:23Z

Builds ready [e4d53f8]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1662 ± 40 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	327	1808	1592	302	145
		domContentLoaded	1501	1797	1636	86	41
		load	1534	1810	1662	84	40
		domInteractive	26	106	44	25	12
		backgroundConnect	10	56	30	16	8
		firstReactRender	14	79	34	25	12
		getState	5	23	8	4	2
		initialActions	0	1	0	0	0
		loadScripts	1118	1378	1230	81	39
		setupStore	7	68	14	17	8
		uiStartup	1759	2384	1944	138	66

metamaskbot · 2025-02-21T01:50:11Z

Builds ready [5f104ac]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1779 ± 106 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1507	2216	1778	219	105
		domContentLoaded	1495	2196	1759	222	107
		load	1509	2204	1779	220	106
		domInteractive	28	75	40	12	6
		backgroundConnect	10	75	19	15	7
		firstReactRender	14	96	34	25	12
		getState	5	80	23	24	11
		initialActions	0	1	0	0	0
		loadScripts	1095	1688	1325	181	87
		setupStore	7	61	22	20	10
		uiStartup	1757	2778	2126	328	158

metamaskbot · 2025-02-21T02:34:01Z

Builds ready [f658768]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1685 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1478	1996	1686	151	73
		domContentLoaded	1465	1922	1660	145	70
		load	1475	1930	1685	148	71
		domInteractive	23	39	30	4	2
		backgroundConnect	11	63	28	15	7
		firstReactRender	14	67	33	22	10
		getState	6	70	20	22	10
		initialActions	0	1	0	0	0
		loadScripts	1062	1471	1250	128	61
		setupStore	8	61	15	15	7
		uiStartup	1742	2214	1958	167	80

ui/helpers/constants/zendesk-url.js

pedronfigueiredo

LGTM

OGPoyraz · 2025-02-25T10:25:26Z

app/scripts/controllers/preferences-controller.ts

+      state.accountUpgradeDisabledChains = [
+        ...(existingDisabledChains ?? []),
+        chainId,
+      ];


Suggested change

state.accountUpgradeDisabledChains = [

...(existingDisabledChains ?? []),

chainId,

];

if (!existingDisabledChains?.includes(chainId)) {

state.accountUpgradeDisabledChains = [

...(existingDisabledChains ?? []),

chainId,

];

}

Would it make sense to add simple if to prevent duplicates?

socket-security · 2025-03-07T23:44:22Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Add cancel modal. Add account card. Add acknowledge checkbox.

metamaskbot · 2025-03-08T01:11:54Z

Builds ready [0a0536d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2073 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	334	2327	1880	518	249
		domContentLoaded	1750	2401	2027	170	81
		load	1763	2465	2073	191	92
		domInteractive	28	141	48	25	12
		backgroundConnect	14	144	49	36	17
		firstReactRender	18	75	45	20	10
		getState	5	69	24	22	10
		initialActions	0	1	0	0	0
		loadScripts	1327	1881	1552	146	70
		setupStore	8	68	21	19	9
		uiStartup	2013	2876	2398	239	115

metamaskbot · 2025-03-08T02:15:28Z

Builds ready [298f1a1]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1955 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1630	2266	1949	201	97
		domContentLoaded	1621	2169	1905	176	85
		load	1630	2282	1955	206	99
		domInteractive	25	72	35	11	5
		backgroundConnect	11	176	52	42	20
		firstReactRender	14	65	28	16	8
		getState	5	100	30	27	13
		initialActions	0	1	0	0	0
		loadScripts	1209	1687	1451	158	76
		setupStore	7	57	16	14	7
		uiStartup	1872	2799	2287	293	141

matthewwalsh0 changed the base branch from main to feat/atomic-batch-transactions February 15, 2025 01:45

matthewwalsh0 added the team-confirmations Push issues to confirmations team label Feb 15, 2025

This comment was marked as spam.

Sign in to view

Emmydon049 approved these changes Feb 15, 2025

View reviewed changes

This comment was marked as spam.

Sign in to view

matthewwalsh0 added the DO-NOT-MERGE Pull requests that should not be merged label Feb 18, 2025

matthewwalsh0 force-pushed the feat/atomic-batch-transactions branch from f377c94 to 29af3c0 Compare February 18, 2025 23:59

matthewwalsh0 marked this pull request as ready for review February 21, 2025 10:46

matthewwalsh0 requested a review from a team as a code owner February 21, 2025 10:46

pedronfigueiredo reviewed Feb 21, 2025

View reviewed changes

ui/helpers/constants/zendesk-url.js Show resolved Hide resolved

pedronfigueiredo approved these changes Feb 21, 2025

View reviewed changes

OGPoyraz approved these changes Feb 25, 2025

View reviewed changes

matthewwalsh0 force-pushed the feat/atomic-batch-transactions branch from eb51b9c to e38a988 Compare March 7, 2025 21:43

matthewwalsh0 requested review from a team as code owners March 7, 2025 21:43

Display 7702 upgrade in confirmation

a7a7f31

Add cancel modal. Add account card. Add acknowledge checkbox.

matthewwalsh0 force-pushed the feat/upgrade-confirmation branch from ca24e1e to a7a7f31 Compare March 8, 2025 00:07

matthewwalsh0 added 2 commits March 8, 2025 00:27

Fix policies

1c3f52c

Revert Yarn lock

0a0536d

Fix linting

298f1a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: account upgrade confirmation #30347

feat: account upgrade confirmation #30347

matthewwalsh0 commented Feb 15, 2025 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 21, 2025

metamaskbot commented Feb 21, 2025

pedronfigueiredo left a comment

OGPoyraz Feb 25, 2025

socket-security bot commented Mar 7, 2025 •

edited

Loading

metamaskbot commented Mar 8, 2025

metamaskbot commented Mar 8, 2025

feat: account upgrade confirmation #30347

Are you sure you want to change the base?

feat: account upgrade confirmation #30347

Conversation

matthewwalsh0 commented Feb 15, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

This comment was marked as spam.

This comment was marked as spam.

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 20, 2025

metamaskbot commented Feb 21, 2025

metamaskbot commented Feb 21, 2025

pedronfigueiredo left a comment

Choose a reason for hiding this comment

OGPoyraz Feb 25, 2025

Choose a reason for hiding this comment

socket-security bot commented Mar 7, 2025 • edited Loading

metamaskbot commented Mar 8, 2025

metamaskbot commented Mar 8, 2025

matthewwalsh0 commented Feb 15, 2025 •

edited

Loading

socket-security bot commented Mar 7, 2025 •

edited

Loading