Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: submit multichain tx #30416

Merged
merged 23 commits into from
Feb 27, 2025
Merged

feat: submit multichain tx #30416

merged 23 commits into from
Feb 27, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Feb 19, 2025

Description

Changes

  • update useLatestBalance to return non-evm balances
  • disable CTA when balance is insuffifient
  • use solana wallet snap to submit transaction

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1869

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

socket-security bot commented Feb 19, 2025

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@micaelae micaelae force-pushed the mms1867-chain-agnostic-bridge-components branch from d6ad1ab to 777a478 Compare February 19, 2025 01:40
@micaelae micaelae force-pushed the mms1869-submit-sol-tx branch from 4baf374 to b99bf92 Compare February 19, 2025 01:43
@micaelae micaelae changed the base branch from mms1867-chain-agnostic-bridge-components to main February 19, 2025 01:43
@micaelae micaelae marked this pull request as ready for review February 19, 2025 01:49
@micaelae micaelae requested a review from a team as a code owner February 19, 2025 01:49
@micaelae micaelae force-pushed the mms1869-submit-sol-tx branch from b99bf92 to 6c9c8f4 Compare February 19, 2025 15:32
ghgoodreau
ghgoodreau previously approved these changes Feb 19, 2025
params: {
request: {
params: { base64EncodedTransactionMessage: txParams },
method: 'sendAndConfirmTransaction',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will soon remove this method and this logic will be on the standard signAndSendTransaction. Let us create a new version of the snap in order to update this

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@micaelae micaelae force-pushed the mms1869-submit-sol-tx branch from 79efaad to a87efb0 Compare February 25, 2025 03:37
@micaelae micaelae force-pushed the mms1869-submit-sol-tx branch from 2680ffe to a4ca36f Compare February 25, 2025 20:46
@micaelae micaelae removed the request for review from a team February 25, 2025 20:53
GustavoRSSilva
GustavoRSSilva previously approved these changes Feb 27, 2025
@ghgoodreau ghgoodreau enabled auto-merge February 27, 2025 17:42
@ghgoodreau ghgoodreau added this pull request to the merge queue Feb 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4af1020]
Page Load Metrics (1878 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint55424361802353169
domContentLoaded139024161848214103
load143524311878213103
domInteractive25146503416
backgroundConnect994382512
firstReactRender147226168
getState572192010
initialActions01000
loadScripts10111986137919292
setupStore76816168
uiStartup161326982115236113
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 61 Bytes (0.00%)
  • ui: 3.58 KiB (0.05%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit e98d34d Feb 27, 2025
79 checks passed
@ghgoodreau ghgoodreau deleted the mms1869-submit-sol-tx branch February 27, 2025 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants