Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @metamask/accounts-controller to ^24.1.0 #30587

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Feb 26, 2025

Description

This new version of the AccountsController.listMultichainAccounts now rely on account.scopes rather than account.type (which was incomplete, since it was only using the CAIP namespace).

This does not have any impact for existing accounts, but it will for accounts (like Bitcoin) that uses different scopes for mainnet and testnet. (Bitcoin support is disabled for now).

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

  1. Create some Ethereum and Solana accounts
  2. Everything should just work as before (listing accounts, selecting accounts during the send flow, etc...)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Feb 26, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None +1 1.09 MB metamaskbot

View full report↗︎

Have feedback? Participate in our User Experience Survey 📊

@metamaskbot
Copy link
Collaborator

Builds ready [cfed914]
Page Load Metrics (1750 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15302140175014771
domContentLoaded15182111172514268
load15802143175014469
domInteractive28123513014
backgroundConnect96826209
firstReactRender1573402512
getState567182010
initialActions01000
loadScripts10821646129112761
setupStore85814147
uiStartup18052464198816378
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -83 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 907 Bytes (0.01%)

@ccharly ccharly changed the title chore: bump accounts-controller chore: bump @metamask/accounts-controller to ^24.1.0 Feb 27, 2025
@ccharly ccharly marked this pull request as ready for review February 27, 2025 08:46
@ccharly ccharly requested review from a team as code owners February 27, 2025 08:46
@metamaskbot
Copy link
Collaborator

Builds ready [0c6f808]
Page Load Metrics (1687 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33920191561406195
domContentLoaded14791954165710751
load14902021168712661
domInteractive256934105
backgroundConnect1294322311
firstReactRender156828189
getState55720199
initialActions01000
loadScripts10921537124010450
setupStore76414147
uiStartup17372361195215574
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -83 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danroc danroc added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit eef1e71 Feb 27, 2025
81 checks passed
@danroc danroc deleted the chore/update-accounts-deps branch February 27, 2025 14:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants