fix: Update decimal precision for account list item and token list #30594

gambinish · 2025-02-26T23:42:37Z

Description

Adds 5 decimal place precision to token cell and account list item. Also should remove trailing zeros.

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-02-26T23:42:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-02-27T16:33:57Z

Builds ready [f3e3d10]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1748 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1526	2272	1758	176	85
		domContentLoaded	1518	2208	1718	162	78
		load	1524	2266	1748	176	84
		domInteractive	26	99	43	22	10
		backgroundConnect	10	184	40	39	19
		firstReactRender	15	76	30	22	10
		getState	4	62	21	21	10
		initialActions	0	1	0	0	0
		loadScripts	1110	1768	1290	147	71
		setupStore	8	35	11	6	3
		uiStartup	1768	2587	2027	201	96

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 286 Bytes (0.00%)
common: 0 Bytes (0.00%)

darkwing · 2025-02-27T16:37:04Z

ui/components/multichain/account-list-item/account-list-item.js

+    const bnBalance = new BigNumber(balanceOrFallback);
+    const formattedBalanceToTranslate = formatWithThreshold(
+      bnBalance.toNumber(),
+      0.00001,


What does this represent?

It's the lower threshold. Meaning, that if the balance is less than 0.00001 we append a < to the threshold and display it.

So if the balance is 0.00000001 we will display <0.00001

This is partially relevant to the ADR we discussed in Slack.

metamaskbot · 2025-02-27T17:10:06Z

Builds ready [5bf785c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1624 ± 93 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	323	2044	1507	424	204
		domContentLoaded	1419	2020	1598	175	84
		load	1428	2035	1624	194	93
		domInteractive	21	111	34	18	9
		backgroundConnect	7	177	30	39	19
		firstReactRender	14	78	38	23	11
		getState	4	49	14	15	7
		initialActions	0	1	0	0	0
		loadScripts	999	1518	1182	135	65
		setupStore	7	56	16	17	8
		uiStartup	1595	2475	1867	252	121

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 286 Bytes (0.00%)
common: 0 Bytes (0.00%)

zone-live

LGTM

metamaskbot · 2025-02-27T18:37:32Z

Builds ready [adde985]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1817 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	323	2076	1653	439	211
		domContentLoaded	1578	2303	1792	155	74
		load	1588	2319	1817	152	73
		domInteractive	28	116	39	18	9
		backgroundConnect	13	75	32	20	10
		firstReactRender	15	75	37	23	11
		getState	5	72	26	24	12
		initialActions	0	1	0	0	0
		loadScripts	1154	1758	1321	131	63
		setupStore	8	59	13	11	5
		uiStartup	1834	2690	2081	191	92

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 286 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-27T22:05:00Z

Builds ready [814e122]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1837 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	322	2139	1763	366	176
		domContentLoaded	1525	2058	1800	145	69
		load	1573	2086	1837	153	73
		domInteractive	28	82	37	12	6
		backgroundConnect	9	198	39	42	20
		firstReactRender	16	76	29	17	8
		getState	4	117	22	27	13
		initialActions	0	0	0	0	0
		loadScripts	1084	1596	1339	137	66
		setupStore	8	60	27	22	11
		uiStartup	1822	2448	2100	178	86

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 286 Bytes (0.00%)
common: 0 Bytes (0.00%)

fix: Update decimal precision for account list item and token list

de76371

metamaskbot added the team-assets label Feb 26, 2025

gambinish marked this pull request as ready for review February 26, 2025 23:47

gambinish requested a review from a team as a code owner February 26, 2025 23:47

fix: Unit tests

a028c65

gambinish requested a review from a team as a code owner February 27, 2025 15:29

gambinish added 2 commits February 27, 2025 07:48

fix: Remove unused imports

678a0ef

fix: e2e for evm balances

f3e3d10

Merge branch 'main' into fix/flask-decimal-places

5bf785c

darkwing reviewed Feb 27, 2025

View reviewed changes

matthewwalsh0 approved these changes Feb 27, 2025

View reviewed changes

zone-live approved these changes Feb 27, 2025

View reviewed changes

vinnyhoward approved these changes Feb 27, 2025

View reviewed changes

gambinish added this pull request to the merge queue Feb 27, 2025

gambinish removed this pull request from the merge queue due to a manual request Feb 27, 2025

Merge branch 'main' into fix/flask-decimal-places

adde985

gambinish added this pull request to the merge queue Feb 27, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025

gambinish added this pull request to the merge queue Feb 27, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025

gambinish added 2 commits February 27, 2025 11:22

Merge branch 'main' into fix/flask-decimal-places

a3ec132

Merge branch 'main' into fix/flask-decimal-places

814e122

gambinish added this pull request to the merge queue Feb 27, 2025

Merged via the queue into main with commit 711ebe8 Feb 27, 2025
79 checks passed

gambinish deleted the fix/flask-decimal-places branch February 27, 2025 22:39

github-actions bot locked and limited conversation to collaborators Feb 27, 2025

metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Feb 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Update decimal precision for account list item and token list #30594

fix: Update decimal precision for account list item and token list #30594

gambinish commented Feb 26, 2025 •

edited

Loading

github-actions bot commented Feb 26, 2025

metamaskbot commented Feb 27, 2025

darkwing Feb 27, 2025

gambinish Feb 27, 2025

metamaskbot commented Feb 27, 2025

zone-live left a comment

metamaskbot commented Feb 27, 2025

metamaskbot commented Feb 27, 2025

fix: Update decimal precision for account list item and token list #30594

fix: Update decimal precision for account list item and token list #30594

Conversation

gambinish commented Feb 26, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 26, 2025

metamaskbot commented Feb 27, 2025

darkwing Feb 27, 2025

Choose a reason for hiding this comment

gambinish Feb 27, 2025

Choose a reason for hiding this comment

metamaskbot commented Feb 27, 2025

zone-live left a comment

Choose a reason for hiding this comment

metamaskbot commented Feb 27, 2025

metamaskbot commented Feb 27, 2025

gambinish commented Feb 26, 2025 •

edited

Loading