Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch between evm<>non-evm networks within Bridge experience #30595

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Feb 26, 2025

Description

Changes

  • dedupes native assets in the Bridge destination asset list
  • change account on network change when switching between evm and non-evm networks

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Switch to Ethereum network and go to Bridge page
  2. Select SOL as the src token
  3. navigate back to the homepage
  4. verify that the network and account are set to solana
  5. Repeat 2,3,4 but from solana to ethereum

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-swaps-and-bridge Team swaps and bridge label Feb 26, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [0a06ed0]
Page Load Metrics (1824 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15382138182218287
domContentLoaded15252109178016579
load15442143182418388
domInteractive28112523115
backgroundConnect11154413617
firstReactRender176927147
getState572292210
initialActions0442105
loadScripts11131660133813665
setupStore85519168
uiStartup18092490208019895
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 295 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae force-pushed the mms1897-switch-to-non-evm-network branch from 0a06ed0 to 6be823b Compare February 27, 2025 01:06
@micaelae micaelae marked this pull request as ready for review February 27, 2025 01:07
@micaelae micaelae requested a review from a team as a code owner February 27, 2025 01:07
@metamaskbot
Copy link
Collaborator

Builds ready [6be823b]
Page Load Metrics (1657 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15071924166011656
domContentLoaded1482177416269646
load15071946165711656
domInteractive24105462311
backgroundConnect9176353718
firstReactRender1472302010
getState44712136
initialActions01000
loadScripts1073134712068340
setupStore75718199
uiStartup17002224188514167
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 594 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit d9f27c4 Feb 27, 2025
82 checks passed
@micaelae micaelae deleted the mms1897-switch-to-non-evm-network branch February 27, 2025 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-swaps-and-bridge Team swaps and bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants