Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: swap input selection defaults #30600

Merged
merged 12 commits into from
Feb 27, 2025
Merged

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Feb 27, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-swaps-and-bridge Team swaps and bridge label Feb 27, 2025
@micaelae micaelae force-pushed the mms1897-swap-asset-selection branch from 3a3e38e to 163cf04 Compare February 27, 2025 03:18
ghgoodreau
ghgoodreau previously approved these changes Feb 27, 2025
@micaelae micaelae force-pushed the mms1897-swap-asset-selection branch from 163cf04 to 19289d3 Compare February 27, 2025 19:28
@micaelae micaelae marked this pull request as ready for review February 27, 2025 19:28
@micaelae micaelae requested a review from a team as a code owner February 27, 2025 19:28
ejwessel
ejwessel previously approved these changes Feb 27, 2025
@micaelae micaelae enabled auto-merge February 27, 2025 22:30
@micaelae micaelae added this pull request to the merge queue Feb 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [94df3db]
Page Load Metrics (1622 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14122323162319292
domContentLoaded13902302159319493
load14272335162219292
domInteractive24100402010
backgroundConnect126630168
firstReactRender1475302010
getState55512136
initialActions01000
loadScripts10101715117315373
setupStore74614136
uiStartup16092552183620598
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -35 Bytes (-0.00%)
  • ui: 449 Bytes (0.01%)
  • common: 480 Bytes (0.00%)

auto-merge was automatically disabled February 27, 2025 22:45

Pull Request is not mergeable

Merged via the queue into main with commit 2505b6f Feb 27, 2025
79 checks passed
@micaelae micaelae deleted the mms1897-swap-asset-selection branch February 27, 2025 23:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge Team swaps and bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants