-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove previousUserTraits from metametrics controller state #30621
Merged
+106
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
a4f0ac1
to
6701546
Compare
Builds ready [41a1918]
Page Load Metrics (1593 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
LGTM ! Can approve once the unit test is fixed |
…have been added with c8995f0
Builds ready [ecceb13]
Page Load Metrics (1708 ± 98 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
Mar 5, 2025
itsyoboieltr
approved these changes
Mar 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-attribution
release-12.15.0
Issue or pull request that will be included in release 12.15.0
team-extension-platform
Extension Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Truly solving https://github.com/MetaMask/MetaMask-planning/issues/3932 required us to clear
previousUserTraits
from metametrics controller state. That property just functions as a cache, and we could actually maintain it in memory.The reason we need to clear it is that there are many users who had the
has_marketing_consent
trait populated totrue
when the application had a bug that prevented that trait from being submitted to segment. That bug is fixed, so new users don't hit that problem. However, to correctly track existing users that havehas_marketing_consent
set to true, we need the comparison of previous and current user traits in the_buildUserTraitsObject
function to fail its equality check.To do that, we are clearing
previousUserTraits
so that, upon update of the extension and when the first metrics event is set to segment, the current user trait values will compare to undefined, and they will all be submitted to segment, includinghas_marketing_consent
.Related issues
Fixes:
Manual testing steps
--
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist