fix: Remove previousUserTraits from metametrics controller state

[danjm]

Description

Truly solving https://github.com/MetaMask/MetaMask-planning/issues/3932 required us to clear previousUserTraits from metametrics controller state. That property just functions as a cache, and we could actually maintain it in memory.

The reason we need to clear it is that there are many users who had the has_marketing_consent trait populated to true when the application had a bug that prevented that trait from being submitted to segment. That bug is fixed, so new users don't hit that problem. However, to correctly track existing users that have has_marketing_consent set to true, we need the comparison of previous and current user traits in the _buildUserTraitsObject function to fail its equality check.

To do that, we are clearing previousUserTraits so that, upon update of the extension and when the first metrics event is set to segment, the current user trait values will compare to undefined, and they will all be submitted to segment, including has_marketing_consent.

Related issues

Fixes:

Manual testing steps

1. Install a build from this branch
2. Open the background console and the network tab
3. Start onboarding. On the metametrics screen, click the checkbox and then "I agree"
4. The network tab should now include a request to segment with user traits, where has_marketing_consent is set to true

--

1. Follow the above steps on the v12.9.3 build (step 4 will fail)
2. Update the version of that install to the build from this branch
3. Log in.
4. The network tab should now include a request to segment with user traits, where has_marketing_consent is set to true

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [41a1918]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1593 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	351	2065	1545	321	154
		domContentLoaded	1374	2049	1565	168	81
		load	1377	2069	1593	170	82
		domInteractive	23	79	39	19	9
		backgroundConnect	8	115	33	26	13
		firstReactRender	14	71	27	20	9
		getState	3	58	11	14	7
		initialActions	0	1	0	0	0
		loadScripts	988	1566	1164	145	70
		setupStore	7	56	15	16	7
		uiStartup	1588	2390	1816	196	94

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 694 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: -22 Bytes (-0.00%)

[DDDDDanica]

LGTM ! Can approve once the unit test is fixed

[metamaskbot]

Builds ready [ecceb13]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1708 ± 98 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1422	2105	1709	202	97
		domContentLoaded	1407	2059	1678	199	96
		load	1420	2096	1708	204	98
		domInteractive	25	142	49	33	16
		backgroundConnect	11	80	32	19	9
		firstReactRender	14	67	30	20	10
		getState	5	61	17	18	9
		initialActions	0	1	0	0	0
		loadScripts	1029	1504	1250	159	76
		setupStore	7	64	18	18	9
		uiStartup	1586	2365	1936	227	109

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 694 Bytes (0.01%)
• ui: 0 Bytes (0.00%)
• common: -22 Bytes (-0.00%)