Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(30662): balance when non evms accounts #30671

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Mar 3, 2025

Description

When the users does not have a non Evm account, the bridge cannot calculated the users balance.

Open in GitHub Codespaces

Related issues

Fixes: #30662

Manual testing steps

  1. Build the App
  2. Go to the brige page

Screenshots/Recordings

Before

After

Screenshot 2025-03-03 at 10 00 26

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested a review from a team as a code owner March 3, 2025 10:10
Copy link
Contributor

github-actions bot commented Mar 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Team swaps and bridge label Mar 3, 2025
@GustavoRSSilva GustavoRSSilva changed the title fix(30662): balance when noe evms accounts fix(30662): balance when non evms accounts Mar 3, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7f0a591]
Page Load Metrics (1692 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15521939169111053
domContentLoaded14961909166111053
load15591945169210953
domInteractive26114392110
backgroundConnect1088342512
firstReactRender1569372211
getState56617189
initialActions01000
loadScripts1081144112349345
setupStore85614147
uiStartup17512109190711756
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 19 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [31514ac]
Page Load Metrics (1553 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1397173215548039
domContentLoaded1391170915307335
load1398173615538139
domInteractive237136157
backgroundConnect106526178
firstReactRender1469352412
getState417732
initialActions00000
loadScripts1007132011457637
setupStore75714147
uiStartup1598197417559244
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 19 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Mar 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2025
@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 8f2f844 Mar 3, 2025
79 checks passed
@GustavoRSSilva GustavoRSSilva deleted the fix-nonEvm-accounts-balance branch March 3, 2025 22:33
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge Team swaps and bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Extension crash when clicking on Bridge button
4 participants