Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add clear functionality to SRP import error banner #30673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Mar 3, 2025

Description

Adds an option to clear the SRP input and error message, so user can easily paste another SRP.

Related issues

Manual testing steps

  1. Go to Import SRP page
  2. Paste SRP that has been already imported (you can try to import the same SRP 2nd time)
  3. Error message should appear with a "Clear" option

Screenshots/Recordings

Before

Screenshot 2025-03-07 at 12 22 56

After

Screenshot 2025-03-07 at 12 29 37

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@PatrykLucka PatrykLucka self-assigned this Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mmi PRs from the MMI team label Mar 3, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4339c06]
Page Load Metrics (1937 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44924151864366176
domContentLoaded16942336190516077
load17112357193716479
domInteractive28139532914
backgroundConnect1179332110
firstReactRender1793322411
getState670242211
initialActions01000
loadScripts12541796143514168
setupStore971242311
uiStartup199027372235209100

Base automatically changed from feat/multi-srp-import-srp to main March 5, 2025 14:15
@PatrykLucka PatrykLucka force-pushed the add-clear-to-srp-input-error branch from 4339c06 to 61b6755 Compare March 7, 2025 11:18
@PatrykLucka PatrykLucka marked this pull request as ready for review March 7, 2025 11:31
@PatrykLucka PatrykLucka requested a review from a team as a code owner March 7, 2025 11:31
@metamaskbot
Copy link
Collaborator

Builds ready [61b6755]
Page Load Metrics (1666 ± 107 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint51419951511352169
domContentLoaded143924061642224108
load144924131666222107
domInteractive24107402211
backgroundConnect96321178
firstReactRender147022157
getState46013168
initialActions01000
loadScripts10591831123418288
setupStore75021189
uiStartup166026311895237114
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants