[DRAFT] ci: prep builds #30720
Open
[DRAFT] ci: prep builds #30720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [eb53869]
Page Load Metrics (1723 ± 59 ms)
Bundle size diffs
|
Builds ready [47b2a3b]
Page Load Metrics (1839 ± 85 ms)
Bundle size diffs
|
Builds ready [486de48]
Page Load Metrics (1837 ± 111 ms)
Bundle size diffs
|
Builds ready [e9f5174]
Page Load Metrics (1540 ± 39 ms)
Bundle size diffs
|
Builds ready [18f2863]
Page Load Metrics (1634 ± 40 ms)
Bundle size diffs
|
Builds ready [bf9aa83]
Page Load Metrics (1956 ± 54 ms)
Bundle size diffs
|
Builds ready [d431b02]
Page Load Metrics (1785 ± 92 ms)
Bundle size diffs
|
Builds ready [1bfbcd5]
Page Load Metrics (1700 ± 53 ms)
Bundle size diffs
|
HowardBraham
reviewed
Mar 6, 2025
Comment on lines
+133
to
+149
| - name: Move test build to dist-test | ||
| run: mv ./dist ./dist-test | ||
|
|
||
| - name: Move test zips to builds-test | ||
| run: mv ./builds ./builds-test |
There was a problem hiding this comment.
The majority of this mv stuff in the prep-build steps is probably unnecessary. It was acrobatics to deal with the way CircleCI workspaces function. In GitHub Actions, it's probably not needed.
makemesteaks
force-pushed
the
ci-prep-build
branch
from
84f79e1 to
22a0b80
Compare
Builds ready [26ce0db]
Page Load Metrics (1645 ± 124 ms)
|
makemesteaks
force-pushed
the
ci-prep-build
branch
from
34d41c5 to
738bc0e
Compare
Builds ready [eb0ba85]
Page Load Metrics (1733 ± 104 ms)
|
Builds ready [f5788c3]
Page Load Metrics (1705 ± 69 ms)
|
|
I have read the CLA Document and I hereby sign the CLA |
Builds ready [5a21082]
Page Load Metrics (1908 ± 110 ms)
|
Builds ready [0f52fd3]
Page Load Metrics (1573 ± 42 ms)
|
Builds ready [8c42f97]
Page Load Metrics (1890 ± 86 ms)
|
Builds ready [6ef5c38]
Page Load Metrics (1718 ± 85 ms)
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const prBodyPath = path.resolve(CHANGED_FILES_DIR, 'pr-body.txt'); | ||
| const labels = prInfo.labels.map(label => label.name).join(', '); | ||
| const updatedPrBody = `PR labels: {${labels}}\nPR base: {${prInfo.base.ref}}\n${prInfo.body.trim()}`; | ||
| fs.writeFileSync(prBodyPath, updatedPrBody); |
Check warning
Code scanning / CodeQL
Network data written to file Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist