Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snap acount creation view position #30721

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

zone-live
Copy link
Contributor

Description

Small fix, its needed for the positioning of the create account view that was being overwritten by the parent confirmations element. This caused the view to appear at the bottom of the screen when the extension is in expand mode.

Related issues

Fixes: The snap create account view appearing at the bottom of the screen.

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Appeared at the bottom of the screen.

After

Screenshot 2025-03-04 at 12 11 40

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested a review from a team as a code owner March 4, 2025 12:13
@metamaskbot metamaskbot added the team-sol PRs from the Solana snap team label Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2711e06]
Page Load Metrics (1657 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14771861165510349
domContentLoaded14661851162610450
load15151861165710048
domInteractive256833126
backgroundConnect106232199
firstReactRender1571302010
getState44311105
initialActions01000
loadScripts1063135111898340
setupStore85313136
uiStartup16852186187012560
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ee3c270]
Page Load Metrics (1621 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1497191516239144
domContentLoaded1455190015999043
load1469191516219244
domInteractive25105392010
backgroundConnect86129178
firstReactRender1473452411
getState55915178
initialActions01000
loadScripts1027146211798642
setupStore76016178
uiStartup16502116183010651
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit 2da9f15 Mar 4, 2025
74 checks passed
@zone-live zone-live deleted the SOL-187-add-account-modal-snap-view branch March 4, 2025 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-sol PRs from the Solana snap team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants