test: remove defaultGanacheOptions

[seaona]

Description

In this PR we remove the defaultGanacheOptions variable from all specs. 2 reasons:

• the default options, are already handled in the node class level, so no need to pass default options in any spec, only custom options
• we are going to use anvil, or other nodes, so this custom variable makes no sense anymore

Note: skip-e2e-quality-gate is added because we modify several spec files, which can take long to run, reaching timeout as they'll all be rerun + 5 times extra, but there should be no functional change, so e2e should continue to work as before

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4348

Manual testing steps

1. All specs should continue to work normally

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [6fc55bf]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1880 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	265	2254	1811	393	189
		domContentLoaded	1640	2182	1849	169	81
		load	1665	2260	1880	176	85
		domInteractive	28	78	42	15	7
		backgroundConnect	13	79	36	20	10
		firstReactRender	14	78	39	25	12
		getState	5	65	19	18	9
		initialActions	0	1	0	0	0
		loadScripts	1222	1621	1388	138	66
		setupStore	8	87	17	20	10
		uiStartup	1892	2716	2159	237	114

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[seaona]

this is '25ETH' to the account corresponding to the default SRP (both ganache and anvil), so it can be removed, as it's in the node class level, and adding this to a spec has no effect

[seaona]

no reason at all to start with a random balance, as this is not checked in the test, which we just check metric related topics, so we can remove it safely

[DDDDDanica]

LGTM !

[davidmurdoch]

Nit: You might be able to remove this one as well right now. The default hardfork in ganache already supports type2 transactions.

[seaona]

good observation !! So at the time the Ganache class was defined, it was set as hardfork: 'muirGlacier', as default, so the majority of specs are using that, unless specifically passing the london flag. In Anvil I also set the same hardfork as default, as several of specs were breaking otherwise, as were relying to type 1 (gas checks and conf screen). We could change that and use london as default in the class, as I guess most of the cases should use type 2 now, so it makes more sense.
I'll take a note on that, if that make sense I can update it in a separate PR, as this change might need some other spec tweaks? I'll wait on your feedback, thank you in advance 🙏

[seaona]

ℹ️ Added a task here for me to address this next: https://github.com/MetaMask/MetaMask-planning/issues/4368

[metamaskbot]

Builds ready [a0e8022]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1745 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	334	2309	1679	342	164
		domContentLoaded	1513	2288	1710	151	73
		load	1535	2313	1745	151	73
		domInteractive	26	190	48	36	17
		backgroundConnect	13	76	40	17	8
		firstReactRender	14	66	22	13	6
		getState	6	51	18	15	7
		initialActions	0	0	0	0	0
		loadScripts	1100	1720	1273	117	56
		setupStore	8	52	12	9	4
		uiStartup	1716	2422	1964	137	66

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)