Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cherry pick accountListItem aggregated fiat balance into v12.14.0 #30786

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Mar 5, 2025

Description

Cherry picks #30581

Related issues

Fixes:

Manual testing steps

  1. Import a solana account
  2. See aggregated balance in main view
  3. Click on account list selector
  4. You should see aggregated fiat balance

Screenshots/Recordings

Before

After

Screen.Recording.2025-02-26.at.19.27.35.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

PR to update token-list-item to show aggregated balance for solana.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30581?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Import a solana account
2. See aggregated balance in main view
3. Click on account list selector
4. You should see aggregated fiat balance


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


https://github.com/user-attachments/assets/311b6e19-c3ec-4159-a08a-511fb59da529


<!-- [screenshots/recordings] -->


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

github-actions bot commented Mar 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri requested a review from danjm March 5, 2025 18:03
@sahar-fehri sahar-fehri changed the title fix: show aggregated balance in account list item (#30581) fix: cherry pick accountListItem aggregated fiat balance into v12.14.0 Mar 5, 2025
@sahar-fehri sahar-fehri marked this pull request as ready for review March 5, 2025 18:16
@sahar-fehri sahar-fehri requested a review from a team as a code owner March 5, 2025 18:16
@metamaskbot
Copy link
Collaborator

Builds ready [fda3766]
Page Load Metrics (1666 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint49618851612282135
domContentLoaded14631878164411857
load14891895166612057
domInteractive146934178
backgroundConnect96428189
firstReactRender1476372512
getState411721
initialActions00000
loadScripts1071138812199646
setupStore759212010
uiStartup16232141189015273

@MajorLift MajorLift merged commit ec2c15a into Version-v12.14.0 Mar 6, 2025
78 of 79 checks passed
@MajorLift MajorLift deleted the fix/cherry-pick-accountListItem branch March 6, 2025 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants