Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: resolve circular imports between permissions.js and selectors.js by moving permissions.js into selectors.js #30791

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Mar 5, 2025

Part of #29927

I tried neatly separating them out but it just kept resulting in more and more circular dependencies issues. So here we are just joining two files together.

For QA/CS:

This PR solves an issue with circular dependencies. It does not change the behavior of the application. It only rearranges functions/files to avoid circular references.

Copy link
Contributor

github-actions bot commented Mar 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@davidmurdoch davidmurdoch changed the title Refactor: resolve circular imports between permissions.js and selectors.js by moving permissions.js into selectors.js refactor: resolve circular imports between permissions.js and selectors.js by moving permissions.js into selectors.js Mar 5, 2025
@davidmurdoch davidmurdoch added the team-extension-platform Extension Platform team label Mar 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [3202baa]
Page Load Metrics (1666 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29018701596321154
domContentLoaded14391846163711354
load14591873166611857
domInteractive25119452612
backgroundConnect96430199
firstReactRender1475372512
getState55212136
initialActions01000
loadScripts10641427123010249
setupStore76116178
uiStartup16632148189813364

@metamaskbot
Copy link
Collaborator

Builds ready [9403dcf]
Page Load Metrics (1955 ± 129 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint164224621950256123
domContentLoaded163224421877223107
load164224761955269129
domInteractive179834168
backgroundConnect12393849043
firstReactRender1595392311
getState698242311
initialActions01000
loadScripts12271838142416981
setupStore7351263
uiStartup182640152306519249
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -1.7 KiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants