Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bridge and Send pages crash when there's no solana account #30793

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Mar 5, 2025

Description

See ticket for details

Open in GitHub Codespaces

Related issues

Fixes: #30792

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added the team-swaps-and-bridge Team swaps and bridge label Mar 5, 2025
@micaelae micaelae requested a review from a team March 5, 2025 23:18
@micaelae micaelae marked this pull request as ready for review March 5, 2025 23:18
@metamaskbot
Copy link
Collaborator

Builds ready [b8c3c58]
Page Load Metrics (1691 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48820481624298143
domContentLoaded14962032166914971
load15062046169115373
domInteractive26573474
backgroundConnect984292010
firstReactRender1473312210
getState46115178
initialActions01000
loadScripts11041587125412962
setupStore75717178
uiStartup17292372193617785
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 30 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@bfullam bfullam added this pull request to the merge queue Mar 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025
@micaelae micaelae added this pull request to the merge queue Mar 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025
@micaelae micaelae added this pull request to the merge queue Mar 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 6, 2025
@bfullam bfullam added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit 97e2028 Mar 7, 2025
78 checks passed
@bfullam bfullam deleted the fix-30792-bridge-send-crash branch March 7, 2025 13:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge Team swaps and bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: EVM Send and Bridge page crash when there's no solana account created
5 participants