Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick c9d7dd1 (#30614) in v12.14.0 #30813

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Mar 6, 2025

Description

Open in GitHub Codespaces

Fix Caip <> Hex conversion error for network switching event

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/858

Manual testing steps

  1. Switch from Solana to Ethereum or other EVM network
  2. See the error in the logs

Screenshots/Recordings

Before

Screenshot 2025-02-27 at 11 27 24

After

The error should not be logged

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30614?quickstart=1)

Fix Caip <> Hex conversion error for network switching event

## **Related issues**

Fixes: NA

## **Manual testing steps**

1. Switch from Solana to Ethereum or other EVM network
2. See the error in the logs

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

![Screenshot 2025-02-27 at 11 27
24](https://github.com/user-attachments/assets/5dbcf7a7-1dda-4628-8c7e-9fbfa03cb898)

### **After**

The error should not be logged

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
@gantunesr gantunesr marked this pull request as ready for review March 6, 2025 11:28
@gantunesr gantunesr requested a review from a team as a code owner March 6, 2025 11:28
@metamaskbot
Copy link
Collaborator

Builds ready [dc57b8f]
Page Load Metrics (1618 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14292070162114971
domContentLoaded13842054158614972
load14222076161814670
domInteractive158330168
backgroundConnect118034209
firstReactRender1469312210
getState55115147
initialActions00000
loadScripts10111543117312861
setupStore75814136
uiStartup16122384182217785

@danjm danjm merged commit 59ad940 into Version-v12.14.0 Mar 7, 2025
79 of 80 checks passed
@danjm danjm deleted the gar/cherry-pick-12.14.0/c9d7dd1 branch March 7, 2025 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants