-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix hideZeroBalance setting for non evm asset list #30816
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -73,3 +74,103 @@ describe('getAssetsRates', () => { | |||
expect(() => getAssetsRates(invalidState)).toThrow(); | |||
}); | |||
}); | |||
|
|||
describe('getMultiChainAssets', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (can be done in a separate PR) - can we add some "equality" check to help reduce selectors from returning new data and causing re-renders. E.g.
it('returns the same data if state does not change', () => {
const result1 = getMultiChainAssets(...)
const result2 = getMultiChainAssets(...)
expect(result1 === result2).toBe(true)
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds ready [29b3073]
Page Load Metrics (1624 ± 52 ms)
|
Builds ready [2f3180d]
Page Load Metrics (1625 ± 56 ms)
|
Builds ready [3c5880e]
Page Load Metrics (1982 ± 108 ms)
Bundle size diffs
|
Description
PR to respect the hideZeroBalance setting in the asset list for non-evm tokens.
Related issues
Fixes: #30623
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-03-06.at.13.46.30.mov
Pre-merge author checklist
Pre-merge reviewer checklist