Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mms-2025 text ellipsis #30845

Merged
merged 3 commits into from
Mar 7, 2025
Merged

fix: mms-2025 text ellipsis #30845

merged 3 commits into from
Mar 7, 2025

Conversation

GustavoRSSilva
Copy link
Contributor

@GustavoRSSilva GustavoRSSilva commented Mar 6, 2025

Description

Add ellipsis to the text in the activity list

Open in GitHub Codespaces

Related issues

Fixes: mms-2025

Manual testing steps

  1. Create a bridge to Binance smart chain
  2. Check the activity text of the transaction

Screenshots/Recordings

Before

Screenshot 2025-03-06 at 22 47 52

After

Screenshot 2025-03-06 at 22 44 34

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GustavoRSSilva GustavoRSSilva requested a review from a team as a code owner March 6, 2025 22:50
Copy link
Contributor

github-actions bot commented Mar 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-swaps-and-bridge Team swaps and bridge label Mar 6, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [caf9831]
Page Load Metrics (1957 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29724541651578277
domContentLoaded160627921930288138
load164528211957291140
domInteractive28139493015
backgroundConnect87532189
firstReactRender1470372110
getState45616168
initialActions01000
loadScripts119722271458248119
setupStore85517147
uiStartup187932212222336162

@metamaskbot
Copy link
Collaborator

Builds ready [7d2cf53]
Page Load Metrics (1718 ± 57 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15511986171811857
domContentLoaded15411884168710550
load15511978171811957
domInteractive17572984
backgroundConnect10119332612
firstReactRender1486372411
getState5103252713
initialActions01000
loadScripts1140143912758842
setupStore75715157
uiStartup178529882012275132
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 13 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GustavoRSSilva GustavoRSSilva enabled auto-merge March 7, 2025 16:38
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@GustavoRSSilva GustavoRSSilva added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit bb8cbdf Mar 7, 2025
74 checks passed
@GustavoRSSilva GustavoRSSilva deleted the mms-2025-ellipsis-text branch March 7, 2025 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-swaps-and-bridge Team swaps and bridge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants