Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate dest assets visible in bridge page #30846

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Mar 6, 2025

Description

Some tokens get displayed twice due to chainIds being in different formats, depending on data source. ERC20 tokens were also not being looked up correctly due to lowercased addresses.

Open in GitHub Codespaces

Related issues

Fixes: #30765

Manual testing steps

  1. Go to Bridge page
  2. Check that there are no duplicate native tokens in src and destination asset picker
  3. Try searching by symbol and verify that list gets updated with matching tokens

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@micaelae micaelae changed the base branch from main to Version-v12.14.0 March 6, 2025 23:09
@micaelae micaelae marked this pull request as ready for review March 6, 2025 23:09
@micaelae micaelae requested a review from a team as a code owner March 6, 2025 23:09
@micaelae micaelae added the team-swaps-and-bridge Team swaps and bridge label Mar 6, 2025
@micaelae micaelae force-pushed the fix-30765-duplicate-dest-asset branch from 22bc5fc to 75f5bb8 Compare March 6, 2025 23:20
@micaelae micaelae force-pushed the fix-30765-duplicate-dest-asset branch from 75f5bb8 to d7e8285 Compare March 6, 2025 23:31
@micaelae micaelae requested review from a team, HowardBraham and dbrans as code owners March 6, 2025 23:31
@micaelae micaelae changed the base branch from Version-v12.14.0 to main March 6, 2025 23:31
@micaelae micaelae removed request for a team, dbrans and HowardBraham March 6, 2025 23:31
GustavoRSSilva
GustavoRSSilva previously approved these changes Mar 6, 2025
ghgoodreau
ghgoodreau previously approved these changes Mar 6, 2025
@micaelae micaelae enabled auto-merge March 7, 2025 15:44
@metamaskbot
Copy link
Collaborator

Builds ready [874472c]
Page Load Metrics (1863 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16272132185614469
domContentLoaded15662090179912259
load16152285186316278
domInteractive26148453517
backgroundConnect10344707335
firstReactRender1476392211
getState4172303919
initialActions01000
loadScripts1197154013649144
setupStore85417157
uiStartup181935202202380182
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -76 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5becba9]
Page Load Metrics (1971 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17262232196415374
domContentLoaded16752198191613565
load17272304197116378
domInteractive27128402411
backgroundConnect12218574722
firstReactRender15183433718
getState6201344220
initialActions01000
loadScripts12451698145811053
setupStore888212110
uiStartup195131192274259125
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -76 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae dismissed stale reviews from GustavoRSSilva and ghgoodreau via d3dcef7 March 7, 2025 21:33
@metamaskbot
Copy link
Collaborator

Builds ready [c1a21b5]
Page Load Metrics (2054 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41325881868518249
domContentLoaded168424921994237114
load169526072054253122
domInteractive26116513115
backgroundConnect8128623818
firstReactRender15100352211
getState6111312412
initialActions01000
loadScripts124819551526209100
setupStore85717147
uiStartup191834012376397191
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -76 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [edbae8f]
Page Load Metrics (2250 ± 227 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38128321936685329
domContentLoaded171734282151402193
load173835202250472227
domInteractive29227655125
backgroundConnect2247610412660
firstReactRender16128522814
getState9189454723
initialActions01000
loadScripts130727981643340163
setupStore9140273215
uiStartup1973586528401055507
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -76 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-swaps-and-bridge Team swaps and bridge
Projects
None yet
4 participants