Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove generateGanacheOptions #30854

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Mar 7, 2025

Description

Removing unnecesay generateGanacheOptions method, in the process of anvil migration.
Skipping quality gate as there are no functional changes.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Check ci jobs - Everything should continue to work normally

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona requested a review from a team as a code owner March 7, 2025 12:31
Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona self-assigned this Mar 7, 2025
@metamaskbot metamaskbot added the team-qa QA team label Mar 7, 2025
@seaona seaona added the area-qa Relating to QA work (Quality Assurance) label Mar 7, 2025
...otherProps, // eg: hardfork
};
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method is not needed, as you can pass any option in the localNodeOptions variable in the test suite, direclty, without any method. The default accounts are already set using the mnemonic at the node class level

localNodeOptions: generateGanacheOptions({
hardfork: 'london',
mnemonic:
'phrase upgrade clock rough situate wedding elder clever doctor stamp excess tent',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mnemonic is also not needed. We have the mnemonic set in the node class level, where we directly seed the accounts

@@ -94,8 +92,6 @@ async function mockSegmentAndMetaswapRequests(mockServer) {
// TODO: (MM-PENDING) These tests are planned for deprecation as part of swaps testing revamp
describe('Swap Eth for another Token', function () {
it('Completes a Swap between ETH and DAI after changing initial rate', async function () {
const { initialBalanceInHex } = genRandInitBal();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a random balance is not needed // nor asserted in this spec, so we default to the regular seeded accounts with 25ETH

@metamaskbot
Copy link
Collaborator

Builds ready [9de3fcd]
Page Load Metrics (1763 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15782050175610852
domContentLoaded15641999172810550
load15792051176311254
domInteractive26111442412
backgroundConnect107740209
firstReactRender1572312010
getState559242110
initialActions01000
loadScripts1127148712838742
setupStore8161121
uiStartup17952330200712761
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona seaona added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit a0b8be9 Mar 7, 2025
95 checks passed
@seaona seaona deleted the remove-generate-ganache-opts branch March 7, 2025 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) release-12.15.0 Issue or pull request that will be included in release 12.15.0 skip-e2e-quality-gate team-qa QA team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants