-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove generateGanacheOptions
#30854
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
...otherProps, // eg: hardfork | ||
}; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this method is not needed, as you can pass any option in the localNodeOptions
variable in the test suite, direclty, without any method. The default accounts are already set using the mnemonic at the node class level
localNodeOptions: generateGanacheOptions({ | ||
hardfork: 'london', | ||
mnemonic: | ||
'phrase upgrade clock rough situate wedding elder clever doctor stamp excess tent', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this mnemonic is also not needed. We have the mnemonic set in the node class level, where we directly seed the accounts
@@ -94,8 +92,6 @@ async function mockSegmentAndMetaswapRequests(mockServer) { | |||
// TODO: (MM-PENDING) These tests are planned for deprecation as part of swaps testing revamp | |||
describe('Swap Eth for another Token', function () { | |||
it('Completes a Swap between ETH and DAI after changing initial rate', async function () { | |||
const { initialBalanceInHex } = genRandInitBal(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having a random balance is not needed // nor asserted in this spec, so we default to the regular seeded accounts with 25ETH
Builds ready [9de3fcd]
Page Load Metrics (1763 ± 54 ms)
Bundle size diffs
|
Description
Removing unnecesay
generateGanacheOptions
method, in the process of anvil migration.Skipping quality gate as there are no functional changes.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist