Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CODEOWNERS file for template renderer #30855

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 7, 2025

Description

This updates the CODEOWNERS file for the ui/components/app/metamask-template-renderer folder to be co-owned by the confirmations team and Snaps team.

Related to: MetaMask/snaps#3206

Open in GitHub Codespaces

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 7, 2025
@Mrtenz Mrtenz marked this pull request as ready for review March 7, 2025 13:13
@Mrtenz Mrtenz requested a review from a team as a code owner March 7, 2025 13:13
GuillaumeRx
GuillaumeRx previously approved these changes Mar 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [2c39bb5]
Page Load Metrics (1859 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16902326186417886
domContentLoaded16662268181617182
load16852336185917886
domInteractive268134126
backgroundConnect11135453416
firstReactRender1675322110
getState66224199
initialActions00000
loadScripts12321791136314268
setupStore8491394
uiStartup186527382108223107
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Co-authored-by: Frederik Bolding <[email protected]>
@metamaskbot
Copy link
Collaborator

Builds ready [3b753dd]
Page Load Metrics (1845 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38524481747361174
domContentLoaded156723741801208100
load157724681845217104
domInteractive25131432813
backgroundConnect1293442813
firstReactRender146524157
getState54918167
initialActions01000
loadScripts11701878137217785
setupStore76018189
uiStartup180529172087274132
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Mrtenz Mrtenz added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit d2d990b Mar 7, 2025
74 checks passed
@Mrtenz Mrtenz deleted the mrtenz/update-codeowners branch March 7, 2025 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants