Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update solana version #30857

Merged
merged 1 commit into from
Mar 7, 2025
Merged

feat: update solana version #30857

merged 1 commit into from
Mar 7, 2025

Conversation

aganglada
Copy link
Contributor

@aganglada aganglada commented Mar 7, 2025

Description

Update solana version:

https://github.com/MetaMask/snap-solana-wallet/releases/tag/v1.11.0

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-sol PRs from the Solana snap team label Mar 7, 2025
Copy link

socket-security bot commented Mar 7, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected]1.11.0 network 0 747 kB metamaskbot

View full report↗︎

Copy link

socket-security bot commented Mar 7, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@aganglada
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/[email protected]

@aganglada aganglada enabled auto-merge March 7, 2025 14:22
@metamaskbot
Copy link
Collaborator

Builds ready [09a3d98]
Page Load Metrics (1866 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint39021451800356171
domContentLoaded15852043181213062
load16262136186615173
domInteractive2597412311
backgroundConnect10175574220
firstReactRender147029189
getState4123283115
initialActions01000
loadScripts12021590137410349
setupStore76016157
uiStartup183428552152258124
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1.22 KiB (0.01%)

@aganglada aganglada added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit b9e9ec0 Mar 7, 2025
79 checks passed
@aganglada aganglada deleted the feat/update-solana branch March 7, 2025 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-sol PRs from the Solana snap team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants