Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snaps): Add AssetSelector #30858

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(snaps): Add AssetSelector #30858

wants to merge 2 commits into from

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Mar 7, 2025

Description

This PR adds a new AssetSelector component to Snap UI.

Open in GitHub Codespaces

Related issues

Fixes: #30575

Manual testing steps

  1. Go to test-snaps
  2. Use the send flow test snap
  3. Look at the asset selector

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Mar 7, 2025
@GuillaumeRx GuillaumeRx changed the title Add AssetSelector feat(snaps): Add AssetSelector Mar 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [9a22941]
Page Load Metrics (2151 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48729412067436209
domContentLoaded17762568207717986
load179730772151265127
domInteractive2111138178
backgroundConnect15389707938
firstReactRender1878392311
getState8185374019
initialActions01000
loadScripts13001993159215775
setupStore96223199
uiStartup209641882532458220
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 79 Bytes (0.00%)
  • ui: 8.68 KiB (0.11%)
  • common: 1001 Bytes (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create AssetSelector for Snap UI and add it to renderer
2 participants