-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cp-12.14.0 fix trezor audit (#30850) #30860
Merged
MajorLift
merged 1 commit into
Version-v12.14.0-beta.0
from
jongsun/cherry-pick-v12.14.0-beta.0/bb391c2
Mar 7, 2025
Merged
chore: cp-12.14.0 fix trezor audit (#30850) #30860
MajorLift
merged 1 commit into
Version-v12.14.0-beta.0
from
jongsun/cherry-pick-v12.14.0-beta.0/bb391c2
Mar 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** We temporarily ignore the `'@trezor/connect-web` audit failure to unblock ci, as upgrading to the new version breaks the webpack build. ``` └─ @trezor/connect-web ├─ ID: @trezor/connect-web (deprecation) ├─ Issue: This version is no longer supported ├─ Severity: moderate ├─ Vulnerable Versions: 9.4.7 │ ├─ Tree Versions │ └─ 9.4.7 │ └─ Dependents └─ metamask-crx@workspace:. ``` [This issue](#30851) is created in order to upgrade to the latest version and remove the entry from the ignore list. [](https://codespaces.new/MetaMask/metamask-extension/pull/30850?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Check yarn audit gh action ## **Screenshots/Recordings** ### Before  ### After  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Frederik Bolding <[email protected]>
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
aganglada
approved these changes
Mar 7, 2025
chloeYue
approved these changes
Mar 7, 2025
Builds ready [dc595a2]
Page Load Metrics (1762 ± 100 ms)
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the bug that causes solana swaps to display as
bridges in the activity tab.
The solution is to check for the txType being 'swap' when mapping the
snap transactions list with the bridge activity list.
This mapping will be removed in the future for a more robust bridge
activity list.
[](https://codespaces.new/MetaMask/metamask-extension/pull/30656?quickstart=1)
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2030
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist