Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cp-12.14.0 fix trezor audit (#30850) #30860

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Mar 7, 2025

Description

This change removes the bug that causes solana swaps to display as
bridges in the activity tab.

The solution is to check for the txType being 'swap' when mapping the
snap transactions list with the bridge activity list.

This mapping will be removed in the future for a more robust bridge
activity list.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30656?quickstart=1)

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-2030

Manual testing steps

  1. Go to this page... 2.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).

  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format
    if applicable
  • I’ve applied the right labels on the PR (see labeling
    guidelines
    ).
    Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

We temporarily ignore the `'@trezor/connect-web` audit failure to
unblock ci, as upgrading to the new version breaks the webpack build.

```
└─ @trezor/connect-web
   ├─ ID: @trezor/connect-web (deprecation)
   ├─ Issue: This version is no longer supported
   ├─ Severity: moderate
   ├─ Vulnerable Versions: 9.4.7
   │ 
   ├─ Tree Versions
   │  └─ 9.4.7
   │ 
   └─ Dependents
      └─ metamask-crx@workspace:.
```

[This
issue](#30851) is
created in order to upgrade to the latest version and remove the entry
from the ignore list.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30850?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Check yarn audit gh action


## **Screenshots/Recordings**

### Before

![Screenshot from 2025-03-07
09-35-05](https://github.com/user-attachments/assets/04fe6b00-93c9-40e3-8b0b-aeb758015ba7)

### After

![Screenshot from 2025-03-07
09-40-00](https://github.com/user-attachments/assets/a895ccfa-8203-4c92-b0dd-61c567cd9f5a)


## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Frederik Bolding <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MajorLift MajorLift self-assigned this Mar 7, 2025
@MajorLift MajorLift added team-extension-platform Extension Platform team and removed team-wallet-framework labels Mar 7, 2025
@MajorLift MajorLift marked this pull request as ready for review March 7, 2025 14:49
@MajorLift MajorLift merged commit cd931f4 into Version-v12.14.0-beta.0 Mar 7, 2025
69 of 71 checks passed
@MajorLift MajorLift deleted the jongsun/cherry-pick-v12.14.0-beta.0/bb391c2 branch March 7, 2025 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [dc595a2]
Page Load Metrics (1762 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37721751680331159
domContentLoaded15181987171011053
load153225541762208100
domInteractive218437157
backgroundConnect116095712861
firstReactRender15178493718
getState5329317134
initialActions01000
loadScripts1112154412698742
setupStore7167213617
uiStartup174547882102629302

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants