Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MegaETH Testnet as a default test network #30871

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

wantedsystem
Copy link
Contributor

@wantedsystem wantedsystem commented Mar 7, 2025

Description

Add MegaETH Testnet to default testnet networks

Related issues

Fixes:

Manual testing steps

  • Click on show test networks
  • You will see Sepolia / Linea Sepolia and MegaETH Testnet
  • Click on MegaETH Testnet
  • Send a transaction
  • Check the transaction result in the explorer

Screenshots/Recordings

Before

Screenshot 2025-03-07 at 18 17 28

After

Screenshot 2025-03-07 at 18 16 48

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • [X ] In case it's not yet "ready for review", I've set it to "draft".
    • [] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@wantedsystem
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot
Copy link
Collaborator

Builds ready [960fbd0]
Page Load Metrics (1703 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15501971170110048
domContentLoaded1541188316728440
load15501983170310350
domInteractive248033157
backgroundConnect1199362713
firstReactRender1373352110
getState584192210
initialActions01000
loadScripts1157142912647235
setupStore75919178
uiStartup17642493194017082
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 426 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 705 Bytes (0.01%)

@wantedsystem wantedsystem marked this pull request as ready for review March 7, 2025 18:45
@dylanbutler1 dylanbutler1 requested a review from salimtb March 7, 2025 19:19
@dylanbutler1 dylanbutler1 requested a review from darkwing March 7, 2025 19:20
@darkwing darkwing added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit 5535411 Mar 7, 2025
82 checks passed
@darkwing darkwing deleted the feat/add-megaeth-tetnet-network branch March 7, 2025 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.15.0 Issue or pull request that will be included in release 12.15.0 team-network-enablement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants