Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use useMemo with Receive Modal #30881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Mar 8, 2025

Description

Prevents re-renders of the receive modal due to passing a likewise but different object.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Ensure correct address shows up when scanning QR code.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner March 8, 2025 02:35
Copy link
Contributor

github-actions bot commented Mar 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [7392979]
Page Load Metrics (1963 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17032435195020599
domContentLoaded16622224190018790
load169927441963247119
domInteractive247234116
backgroundConnect155677011756
firstReactRender15118372613
getState5239395326
initialActions01000
loadScripts12751719143614369
setupStore984262411
uiStartup188052342414697335
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 601 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants