feat: updated wallet ready page PR - 2 #36839
Open
+283
−554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgv
requested review from
LeVinhGithub,
chaitanyapotti and
himanshuchawla009
smgv
added
needs-qa
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +0 -14)
🔐 @MetaMask/web3auth (8 files, +264 -198)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e9b47f8]
UI Startup Metrics (1233 ± 67 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [4697a9b]
UI Startup Metrics (1266 ± 75 ms)
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0c21d2a]
UI Startup Metrics (1266 ± 77 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [30d14ed]
UI Startup Metrics (1225 ± 83 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [d964a29]
UI Startup Metrics (1239 ± 76 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [f3c370f]
UI Startup Metrics (1207 ± 53 ms)
|
smgv
changed the title
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1e3a102]
UI Startup Metrics (1280 ± 96 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [5590366]
UI Startup Metrics (1241 ± 60 ms)
|
seaona
reviewed
Oct 16, 2025
| } | ||
|
|
||
| async createWalletWithSrp(socialLoginEnabled = true): Promise<void> { | ||
| await this.driver.delay(largeDelayMs); |
There was a problem hiding this comment.
could we avoid using a hardcoded delay and wait for a condition instead?
There was a problem hiding this comment.
I added that for testing and forgot to remove the error. Thank you for pointing this out!
PR Updated @seaona
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [86ee35f]
UI Startup Metrics (1235 ± 65 ms)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [2b8b1c7]
UI Startup Metrics (1227 ± 57 ms)
|
LeVinhGithub
added
QA Passed
and removed
needs-qa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, we have updated the wallet-ready page. Specifically, we have replaced the "Remind Me Later" UI with the content on the wallet-ready page. Changes include removing all previous content and replacing it with a simple title—Your wallet is ready. Additionally, we introduced a Rive animation loader and positioned the "Manage Settings" text button below the "Done" button.
Jira Link: https://consensyssoftware.atlassian.net/browse/SL-54
Figma Link: https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding?node-id=16495-182046&m=dev
Changelog
CHANGELOG entry: we have updated the wallet-ready page
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-10-14.at.5.45.55.PM.mov
Screen.Recording.2025-10-15.at.1.22.21.PM.mov
Screen.Recording.2025-10-15.at.1.22.38.PM.mov
Fixed Word Wrap in Review SRP UI:
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Simplifies the wallet-ready screen with a new Rive animation and settings link, removes “remind me later”/social copy, consolidates SRP review strings, and updates styles, header logic, tests, and i18n.
ui/pages/onboarding-flow/creation-successful/creation-successful.js: Simplifies content to "Your wallet is ready", addsWalletReadyAnimation, moves "Manage default settings" to a link under the Done button, and adds conditional copy when opened from SRP backup reminder.onboarding-app-header.js: Shows pin banner only when not coming from SRP reminder/settings.creation-successful/index.scssfor animation container/title.wallet-ready-animation.tsxusing Rive; skips CDN in tests.review-recovery-phrase.js: Inlines the “Don’t share it…” sentence intoseedPhraseReviewDetails; removes extra text node.creation-successful.test.js,onboarding-flow.test.js; snapshot updates for SRP copy.onboarding-complete-page.ts.seedPhraseReviewDetails2intoseedPhraseReviewDetails(en and snapshots), updates descriptions across locales.walletReadyLearnRemind,walletReadyLoseSrpRemind,walletReadySocialDetails1/2,yourWalletIsReadyRemindacross locales.Written by Cursor Bugbot for commit 2b8b1c7. This will update automatically on new commits. Configure here.