Skip to content

Conversation

@khanti42
Copy link
Contributor

@khanti42 khanti42 commented Oct 14, 2025

Description

This PR updates network and native token logos for Cronos network.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: updates network and native token logos for Cronos network.

Related issues

Fixes:

Manual testing steps

Go to the MetaMask Mobile app
1/ Navigate to "chainList.org" search for CRONOS and click add new network.
2/ Confirm that the network logo is displayed correctly
3/ Confirm that the native Token logo is displayed correctly

Screenshots/Recordings

After

Screenshot 2025-10-14 at 21 51 46 Screenshot 2025-10-14 at 21 51 53

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates Cronos SVG asset and wires it as both the network and native token icon via new CRONOS_NATIVE_TOKEN_IMAGE_URL and mapping changes.

  • Assets:
    • Replace app/images/cronos.svg with new 125x125 SVG (gradient, blue variant).
  • Shared constants (shared/constants/network.ts):
    • Add CRONOS_NATIVE_TOKEN_IMAGE_URL pointing to ./images/cronos.svg.
    • Map CHAIN_IDS.CRONOS to CRONOS_NATIVE_TOKEN_IMAGE_URL in CHAIN_ID_TOKEN_IMAGE_MAP.
    • Keep network image mapping to CRONOS_IMAGE_URL for CHAIN_IDS.CRONOS.

Written by Cursor Bugbot for commit f861dbc. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

❌ test-e2e-chrome-api-specs failed. View the html report here.

@khanti42 khanti42 marked this pull request as ready for review October 14, 2025 19:53
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: e8a647f | Date: 10/14/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.07s (±77ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 754ms (±87ms) 🟢 | historical mean value: 738ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 89ms (±127ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.07s 77ms 1.02s 1.37s 1.32s 1.37s
domContentLoaded 754ms 87ms 705ms 1.29s 984ms 1.29s
firstPaint 89ms 127ms 60ms 1.35s 88ms 1.35s
firstContentfulPaint 89ms 127ms 60ms 1.35s 88ms 1.35s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [e8a647f]
UI Startup Metrics (1273 ± 105 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup12731109204710513001432
load1101973187210211351255
domContentLoaded1095968185610111271248
domInteractive18144881743
firstPaint81378188843611131248
backgroundConnect2562402777261268
firstReactRender26204462941
getState1254461424
initialActions507610510
loadScripts845721159599874994
setupStore953541016
WebpackHomeuiStartup798686105070809981
load62557090571628822
domContentLoaded61856488870624806
domInteractive15115071335
firstPaint19257919187190582
backgroundConnect20114772431
firstReactRender25165573033
getState84193912
initialActions2013226
loadScripts61556287768622795
setupStore84172911
FirefoxBrowserifyHomeuiStartup14351228216513414791686
load1224106015959312791370
domContentLoaded1223106015959312781369
domInteractive1073640159105242
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3219220233360
firstReactRender30258773137
getState8210612626
initialActions30497215
loadScripts1199104115468712541345
setupStore12420126758
WebpackHomeuiStartup15851382206513716321917
load13751201172910214341598
domContentLoaded13751201172810214341597
domInteractive96343846298205
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3419170203768
firstReactRender3627120123774
getState10214720642
initialActions30345212
loadScripts1349118516869413921566
setupStore15425429862
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 120 Bytes (0%)

Copy link
Contributor

@vivek-consensys vivek-consensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khanti42 khanti42 added the skip-e2e skip E2E test jobs label Oct 16, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 776487d | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±72ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±69ms) 🟢 | historical mean value: 737ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±13ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 72ms 1.01s 1.32s 1.30s 1.32s
domContentLoaded 732ms 69ms 698ms 996ms 950ms 996ms
firstPaint 75ms 13ms 60ms 192ms 84ms 192ms
firstContentfulPaint 75ms 13ms 60ms 192ms 84ms 192ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [776487d]
UI Startup Metrics (1252 ± 73 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1252113116187312991380
load107697613446311061181
domContentLoaded107097013406311011175
domInteractive181393101738
firstPaint66189123843610851169
backgroundConnect2552412878258268
firstReactRender2719159172642
getState175110142040
initialActions40213510
loadScripts821710107661850921
setupStore1063551120
WebpackHomeuiStartup850735111262873992
load64159393263650833
domContentLoaded63358792062642824
domInteractive16124681439
firstPaint18855832185197627
backgroundConnect22104972634
firstReactRender28176783335
getState941731215
initialActions307247
loadScripts63058590760640814
setupStore1061731214
FirefoxBrowserifyHomeuiStartup14571302187011315151698
load1226109714668112841376
domContentLoaded1226109714668112831376
domInteractive1023526853103233
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect342394103948
firstReactRender31265353141
getState94555915
initialActions51315415
loadScripts1203108114307812601356
setupStore12658101138
WebpackHomeuiStartup15821373308519316311835
load1338119818719613941499
domContentLoaded1337119818699613941499
domInteractive983137056103152
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3920289324193
firstReactRender3526145183574
getState123126171139
initialActions7122823322
loadScripts1312118117848713611454
setupStore13691141151
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 120 Bytes (0%)

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Oct 17, 2025
Copy link
Contributor

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the two SVGs here identical? If so, why?

@github-project-automation github-project-automation bot moved this from Needs dev review to Needs more work from the author in PR review queue Oct 29, 2025
@khanti42 khanti42 requested a review from davidmurdoch November 5, 2025 13:03
@metamaskbot
Copy link
Collaborator

Builds ready [f861dbc]
UI Startup Metrics (1214 ± 89 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1214107316598912531402
load103892513518110711218
domContentLoaded103087513428210671208
domInteractive211574141863
firstPaint59372128641810291169
backgroundConnect23221734116234249
firstReactRender27185683045
getState2075992436
initialActions60417718
loadScripts805657110482837970
setupStore1172741219
numNetworkReqs1367619671
BrowserifyPower User HomeuiStartup18201604252330020732523
load935822132818111401328
domContentLoaded926816130017811311300
domInteractive261558164558
firstPaint704170134241511361342
backgroundConnect19218322412198224
firstReactRender292363112763
getState17115022920187229
initialActions428268
loadScripts74263810981709261098
setupStore1182651126
numNetworkReqs1187125467177254
WebpackStandard HomeuiStartup8507231240848611086
load61756597071617838
domContentLoaded61056095268610817
domInteractive16125191540
firstPaint21865849212188734
backgroundConnect251256122554
firstReactRender30178193439
getState1162941316
initialActions41264510
loadScripts60755894265608806
setupStore1163041318
numNetworkReqs1367219871
WebpackPower User HomeuiStartup12961123177920014911779
load63057580081703800
domContentLoaded61156178171659781
domInteractive27121543433154
firstPaint34778784278703784
backgroundConnect4792986854298
firstReactRender26233122731
getState14910917818158178
initialActions51318731
loadScripts60755977067649770
setupStore1262771327
numNetworkReqs1036719748168197
FirefoxBrowserifyStandard HomeuiStartup15131318198912715841735
load1280113016579913551428
domContentLoaded1279113016569913541428
domInteractive1143527245127226
firstPaint------
backgroundConnect4526161215280
firstReactRender26225752739
getState84647718
initialActions51616412
loadScripts1253110616359513231400
setupStore157206201329
numNetworkReqs1266315756
BrowserifyPower User HomeuiStartup23682021299632024722996
load13361122169819516181698
domContentLoaded13351122169819516181698
domInteractive18488526144321526
firstPaint------
backgroundConnect11839445108210445
firstReactRender412787144887
getState1267018430161184
initialActions13199231499
loadScripts12971103167219515631672
setupStore28772205272
numNetworkReqs1337030279193302
WebpackStandard HomeuiStartup15901382215413516301912
load1363120216279514091553
domContentLoaded1362120216269514081553
domInteractive1003036042113166
firstPaint------
backgroundConnect4320135204989
firstReactRender312278132970
getState945810645
initialActions51829319
loadScripts1333118715939213811529
setupStore14798131350
numNetworkReqs1267416763
WebpackPower User HomeuiStartup26442310300021428253000
load16011348187916318211879
domContentLoaded16011347187816318211878
domInteractive18144507147336507
firstPaint------
backgroundConnect1075427871135278
firstReactRender36334643846
getState1186620829125208
initialActions622871128
loadScripts15591316183715517531837
setupStore301185297785
numNetworkReqs1316723765200237
📊 Page Load Benchmark Results

Current Commit: f861dbc | Date: 11/5/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 977ms (±41ms) 🟢 | historical mean value: 1.02s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 680ms (±56ms) 🟢 | historical mean value: 713ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 85ms (±117ms) 🟢 | historical mean value: 76ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 977ms 41ms 946ms 1.29s 1.01s 1.29s
domContentLoaded 680ms 56ms 655ms 1.19s 704ms 1.19s
firstPaint 85ms 117ms 60ms 1.25s 84ms 1.25s
firstContentfulPaint 85ms 117ms 60ms 1.25s 84ms 1.25s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 5.46 KiB (0.12%)
  • ui: 171.83 KiB (2.41%)
  • common: 10.27 KiB (0.12%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Needs more work from the author

Development

Successfully merging this pull request may close these issues.

5 participants