-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: update cronos network images #36857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e8a647f]
UI Startup Metrics (1273 ± 105 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [776487d]
UI Startup Metrics (1252 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the two SVGs here identical? If so, why?
776487d to
f861dbc
Compare
Builds ready [f861dbc]
UI Startup Metrics (1214 ± 89 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR updates network and native token logos for Cronos network.
Changelog
CHANGELOG entry: updates network and native token logos for Cronos network.
Related issues
Fixes:
Manual testing steps
Go to the MetaMask Mobile app
1/ Navigate to "chainList.org" search for CRONOS and click add new network.
2/ Confirm that the network logo is displayed correctly
3/ Confirm that the native Token logo is displayed correctly
Screenshots/Recordings
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Updates Cronos SVG asset and wires it as both the network and native token icon via new
CRONOS_NATIVE_TOKEN_IMAGE_URLand mapping changes.app/images/cronos.svgwith new 125x125 SVG (gradient, blue variant).shared/constants/network.ts):CRONOS_NATIVE_TOKEN_IMAGE_URLpointing to./images/cronos.svg.CHAIN_IDS.CRONOStoCRONOS_NATIVE_TOKEN_IMAGE_URLinCHAIN_ID_TOKEN_IMAGE_MAP.CRONOS_IMAGE_URLforCHAIN_IDS.CRONOS.Written by Cursor Bugbot for commit f861dbc. This will update automatically on new commits. Configure here.