-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: use correct href for phishing page proceed anyway button #36871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e22fdb4]
UI Startup Metrics (1232 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e22fdb4]
UI Startup Metrics (1248 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [80bac5e]
UI Startup Metrics (1258 ± 70 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [879d2b4]
UI Startup Metrics (1236 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR makes several small optimizations and bug fixes to the way we capture metrics and display URLs for our phishing page.
hostname
now. Previously, blockedUrl being set todetails.initiator
would add ahttps://
prefix to our metrics whereashostname
would be tracked without it.Changelog
CHANGELOG entry: fix: use correct href for phishing page proceed anyway button
Screenshots/Recordings
Before
Website blocked by c2:
After
Website blocked by c2:
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Corrects phishing warning flow to display/proceed to the correct URL while standardizing metrics to use hostname.
app/scripts/background.js
):href
asblockedUrl
and deriveblockedHostname
safely (fallback to originalhostname
/href
on parse errors).url
andreferrer.url
asblockedHostname
for consistency.blockedUrl
withdetails.initiator
for display/proceed behavior.hostname
toblockedHostname
andhref
toblockedUrl
for the phishing warning page.Written by Cursor Bugbot for commit 879d2b4. This will update automatically on new commits. Configure here.