fix: cp-13.5.0 Fix account icons in send flow #36877
Merged
+252
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
added
the
no-changelog
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (11 files, +252 -10)
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [83dcf90]
UI Startup Metrics (1237 ± 59 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [fc4c816]
UI Startup Metrics (1219 ± 70 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jpuri
reviewed
Oct 15, 2025
| > | ||
| <Box alignItems={AlignItems.center} display={Display.Flex}> | ||
| <PreferredAvatar | ||
| address={resolvedAddress} |
There was a problem hiding this comment.
It is bit big piece of code inline.
pedronfigueiredo
previously approved these changes
Oct 15, 2025
jpuri
reviewed
Oct 15, 2025
| }, [accountGroupsWithAddresses]); | ||
|
|
||
| return { accountAddressSeedIconMap }; | ||
| }; |
There was a problem hiding this comment.
Here we are creating this map for all accounts, can we optimise this for only the concerned account ?
There was a problem hiding this comment.
The current map-based approach is already optimized for the actual usage patterns where we need seed icons for many/all addresses simultaneously. The only case where per-address lookup would be better is if we only had the single lookup in recipient-input.tsx, but since the other hooks process bulk addresses, the current design is more performant.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [596eb60]
UI Startup Metrics (1272 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
approved these changes
Oct 16, 2025
vinistevam
approved these changes
Oct 16, 2025
metamaskbot
added
the
release-13.6.0
|
Hi @OGPoyraz, is this PR user-facing? If yes, what would be the user-facing CHANGELOG entry? If not, can you please set CHANGELOG entry to "null"? |
|
Hey @gauthierpetetin, the feature is not yet released in the previous versions hence I didn't put any changelog on that. |
|
ok thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to centralise seed account icon map in a hook and use it in send flow.
Changelog
CHANGELOG entry: null
Related issues
Fixes: #36657
Manual testing steps
Account icon should be consistent as other parts of the wallet.
Screenshots/Recordings
Before
After
AccountIcons.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Introduces a hook to map account addresses to seed-icon addresses and integrates it across send flow to render consistent avatars, updating recipient types and tests.
useAccountAddressSeedIconMapto build a map of account addresses -> seed icon address from account groups.useAccountRecipientsanduseContactRecipientsto attachseedIconto eachRecipient.Recipient: passrecipient.seedIcon ?? addresstoPreferredAvatar.RecipientInput: compute avatar seed address from the map and use it inPreferredAvatarwhen a recipient is resolved.Recipientwith optionalseedIcon.useAccountAddressSeedIconMap.recipient-input.test.tsx,recipient.test.tsx,useAccountRecipients.test.ts, anduseContactRecipients.test.tsto account for the new hook andseedIcon.Written by Cursor Bugbot for commit 596eb60. This will update automatically on new commits. Configure here.