-
Notifications
You must be signed in to change notification settings - Fork 5.4k
feat: add option show loader when status is not yet available #36888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +6 -9)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [bb2917d]
UI Startup Metrics (1251 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ae42da5]
UI Startup Metrics (1261 ± 68 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b4cb0c1]
UI Startup Metrics (1238 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [9c9e421]
UI Startup Metrics (1241 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Show skeleton loader when loading status for Shield Coverage
https://www.figma.com/design/HTAO1SrmixV4ppv7qIvLoa/Metamask-Transaction-Shield?node-id=12570-88009&t=mNinFtkACmFpqbjG-4
Description
Changelog
CHANGELOG entry: Show skeleton loader when loading status for Shield Coverage
Related issues
Fixes:
Manual testing steps
https://metamask.github.io/test-dapp/
and ConnectMalicious ETH Transfer
Screenshots/Recordings
Before
tx-shield-no-loader.mov
After
tx-shield-with-loader.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds a skeleton loader for the Shield coverage indicator and makes subscription hooks refetchable, updating settings and plan pages to always fetch latest data.
ConfirmInfoAlertRow
: addsshowAlertLoader
prop and rendersSkeleton
when alerts are not yet loaded; used inshield-footer-coverage-indicator
.useUserSubscriptions
: accepts{ refetch }
, fetches only when signed-in and unlocked; usesuseAsyncResult
.useSubscriptionPricing
: accepts{ refetch }
, switched touseAsyncResult
for loading/error state.useEnableShieldCoverageChecks
: simplified to derive fromsubscriptions
withuseMemo
.transaction-shield
andshield-plan
: call hooks with{ refetch: true }
and show loaders accordingly.useSubscriptionPricing
error to beundefined
.Written by Cursor Bugbot for commit 9c9e421. This will update automatically on new commits. Configure here.