-
Notifications
You must be signed in to change notification settings - Fork 5.4k
fix: Sponsored transaction by normalising calldata handling #36902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+51
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +5 -1)
|
a605f72
to
1403824
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [1403824]
UI Startup Metrics (1212 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
approved these changes
Oct 16, 2025
OGPoyraz
approved these changes
Oct 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
no-changelog
no-changelog Indicates no external facing user changes, therefore no changelog documentation needed
release-13.6.0
Issue or pull request that will be included in release 13.6.0
size-S
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Normalizes calldata and keeps caveat terms byte-identical to execution, while sending sponsored transactions through the delegation publish hook.
#normalizeCallData
to canonicalizetxParams.data
(lowercase,0x
-prefixed, even-length) and use it in#buildExecutions
and#buildCaveats
.transactionMeta.isGasFeeSponsored
in the non-smart/non-send-bundle condition inpublishHook
.exactExecutionBuilder
: reuseencodeSingleExecution
soterms
match the execution payload; relax data validation to accept empty calldata as0x
(not0x0
).Written by Cursor Bugbot for commit 1403824. This will update automatically on new commits. Configure here.