test: Refactor e2e multichain account tests #36906
Merged
+555
−262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (7 files, +299 -232)
🧪 @MetaMask/qa (7 files, +251 -27)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [12fbe14]
UI Startup Metrics (1250 ± 72 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davibroc
force-pushed
the
test/BIP44-refactor-e2e-tests
branch
from
12fbe14 to
73c6016
Compare
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0abdc8f]
UI Startup Metrics (1245 ± 82 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davibroc
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
davibroc
added
the
no-changelog
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [b7ebdfd]
UI Startup Metrics (1169 ± 60 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0fca5df]
UI Startup Metrics (1235 ± 59 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [de20106]
UI Startup Metrics (1272 ± 74 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
davibroc
force-pushed
the
test/BIP44-refactor-e2e-tests
branch
from
de20106 to
dc40b3f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [dc50b9b]
UI Startup Metrics (1230 ± 64 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [e7adba5]
UI Startup Metrics (1256 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
racitores
approved these changes
Oct 17, 2025
PatrykLucka
approved these changes
Oct 17, 2025
metamaskbot
added
the
release-13.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors multichain accounts E2E to state 2 with new page objects and feature-flag mocks, selector updates, added testids, and minor timing tweaks.
Account details,Addresses,Rename).forceBip44VersiontowithFixturesand apply multichain feature-flag mocks (feature-flag-mocks.ts).withMultichainAccountsDesignEnabledto state 2; allow multiple mocked endpoints; update imported-account helper for state 2.stateand passesforceBip44Version.multichain/account-address-modal.ts,multichain/address-list-modal.ts,multichain/private-key-modal.ts.multichain-account-details-page.ts(confirm button, networks row, wallet link) andmultichain-wallet-details-page.ts(header text).account-list-page.ts: update menu/tab text, add helpers (e.g.,checkAddWalletButttonIsDisplayed,checkAccountNameIsDisplayed).address-qr-code-modal: adddata-testid="account-address"anddata-testid="view-address-on-etherscan"for E2E.Written by Cursor Bugbot for commit e7adba5. This will update automatically on new commits. Configure here.