Skip to content

Conversation

bitgamma
Copy link

@bitgamma bitgamma commented Oct 16, 2025

Description

This PR adds Keycard Shell to the list of supported QR hardware wallets. We have performed extensive tests between Keycard Shell and MetaMask and can confirm full compatibility.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Added Keycard Shell to the list of QR-based hardware wallets

Related issues

Fixes: N/A

Manual testing steps

  1. Add hardware wallet account
  2. Select QR-based
  3. See Keycard Shell in the list of wallets

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds Keycard Shell as a QR hardware wallet option with buy/tutorial links, i18n strings, and issue template entry.

  • UI:
    • Add Keycard Shell option in ui/pages/create-account/connect-hardware/select-hardware.js with Buy Now and Tutorial buttons, opening HardwareAffiliateLinks.kshell and HardwareAffiliateTutorialLinks.kshell, and tracking click events.
  • Shared Constants:
    • Add kshell entries to HardwareAffiliateLinks and HardwareAffiliateTutorialLinks in shared/constants/hardware-wallets.ts.
  • i18n:
    • Add keycardShell message across locale files in app/_locales/*/messages.json.
  • GitHub Templates:
    • Add Keycard Shell to hardware wallet options in .github/ISSUE_TEMPLATE/bug-report.yml.

Written by Cursor Bugbot for commit de3419a. This will update automatically on new commits. Configure here.

Copy link
Contributor

github-actions bot commented Oct 16, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 16, 2025
@bitgamma
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 16, 2025
@bitgamma bitgamma marked this pull request as ready for review October 16, 2025 03:23
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants