chore: add Keycard Shell to the list of supported QR hardware wallets #36911
+93
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Keycard Shell to the list of supported QR hardware wallets. We have performed extensive tests between Keycard Shell and MetaMask and can confirm full compatibility.
Changelog
CHANGELOG entry: Added Keycard Shell to the list of QR-based hardware wallets
Related issues
Fixes: N/A
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds Keycard Shell as a QR hardware wallet option with buy/tutorial links, i18n strings, and issue template entry.
ui/pages/create-account/connect-hardware/select-hardware.js
withBuy Now
andTutorial
buttons, openingHardwareAffiliateLinks.kshell
andHardwareAffiliateTutorialLinks.kshell
, and tracking click events.kshell
entries toHardwareAffiliateLinks
andHardwareAffiliateTutorialLinks
inshared/constants/hardware-wallets.ts
.keycardShell
message across locale files inapp/_locales/*/messages.json
.Keycard Shell
to hardware wallet options in.github/ISSUE_TEMPLATE/bug-report.yml
.Written by Cursor Bugbot for commit de3419a. This will update automatically on new commits. Configure here.