Skip to content

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Oct 16, 2025

Description

This PR tests the guaranteed working baseline to confirm popover positioning works correctly.

Testing from commit be2a698ffb ("release: Bump main version to 13.6.0") which is the commit directly after 13.5.0 was cut from main. This should be a guaranteed working baseline since 13.5.0 CI builds definitively have working popovers.

Expected Result: Popovers should position correctly in GitHub Actions builds.

Purpose:

  • Establish a confirmed working baseline for git bisect
  • Rule out any environmental factors in current CI setup
  • Confirm our understanding that the issue started after 13.5.0

If this works as expected, we can use this as the "good" commit for git bisect between here and current main to find the exact breaking commit.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Testing baseline for popover positioning issue affecting ALL popover components in main branch CI builds.

Manual testing steps

  1. Wait for GitHub Actions to build this PR
  2. Download the built extension artifacts
  3. Load the extension in browser
  4. Test popover positioning:
    • Click the account menu (top-right)
    • Click the global menu (hamburger icon)
    • Open network selector
    • Verify popovers anchor correctly to their reference elements

Expected Result: All popovers should position correctly since this is the guaranteed working 13.6.0 baseline.

Screenshots/Recordings

Expected Result

Popovers should correctly anchor to their reference elements in GitHub Actions builds, matching the behavior seen in 13.5.0 builds.

Technical Notes

  • Baseline Commit: be2a698ffb - Release bump to 13.6.0 (directly after 13.5.0)
  • Known Working: 13.5.0 CI builds have functional popovers
  • Next Step: If confirmed working, use for git bisect against main branch
  • Issue: ALL popovers float unanchored in current main branch CI builds

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This commit represents the guaranteed working baseline from when 13.6.0
was released, which should have working popover positioning in CI builds.

Testing to establish baseline for git bisect to find actual breaking commit.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Extension label Oct 16, 2025
@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 672404f | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±71ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 735ms (±69ms) 🟢 | historical mean value: 734ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 71ms 1.00s 1.32s 1.28s 1.32s
domContentLoaded 735ms 69ms 697ms 1.01s 947ms 1.01s
firstPaint 77ms 12ms 60ms 184ms 88ms 184ms
firstContentfulPaint 77ms 12ms 60ms 184ms 88ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [672404f]
UI Startup Metrics (1252 ± 92 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1252113719439212931358
load107296017178511071165
domContentLoaded106595417098410951162
domInteractive17135671736
firstPaint68478118842810921151
backgroundConnect25323636514257270
firstReactRender2819144172846
getState17671102137
initialActions60607612
loadScripts819720145383853916
setupStore1062641120
WebpackHomeuiStartup8447191109808551044
load64458393688643887
domContentLoaded63757792686636878
domInteractive15115681434
firstPaint18557912183195608
backgroundConnect22114172637
firstReactRender2717139133234
getState932741115
initialActions3011247
loadScripts63457591985634869
setupStore951431113
FirefoxBrowserifyHomeuiStartup14001218174711614661627
load1181104115039212591317
domContentLoaded1181104015039212581317
domInteractive1043328955106244
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3420106153868
firstReactRender29255952943
getState84496820
initialActions4263639
loadScripts1158102614608912381292
setupStore146142231062
WebpackHomeuiStartup15881392204613416491910
load1346118817289813961529
domContentLoaded1345118717279813961529
domInteractive1063240975102348
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3622132144057
firstReactRender352784123677
getState1149613932
initialActions9026030318
loadScripts1321117116139313711502
setupStore156214271037
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 28.99 KiB (0.64%)
  • ui: -50.75 KiB (-0.78%)
  • common: 8.38 KiB (0.1%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-M team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants