release: sync stable to main for version 13.4.3 #36914
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR updates the change log for 13.4.3. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/36813?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates `CHANGELOG.md` for 13.4.3 with a fix for path-based URL blocking and refreshes compare links. > > - **Changelog (`CHANGELOG.md`)**: > - **13.4.3 (Fixed)**: Add path-based URL blocking entry (#36634). > - **Links**: Update `[Unreleased]` to compare from `v13.4.3` and add `[13.4.3]` compare link. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c6cec8c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
- feat: path based blocking (#36634) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Introduces URL path based blocking within the extension. This allows websites like `example.com/path` to be blocked rather than blocking all of `example.com`. [](https://codespaces.new/MetaMask/metamask-extension/pull/36634?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Added path-based blocking for URLs ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to `sites.google.com/view/aoooop/aave-com` and make sure that it you are redirected to the Phishing Warning Page 2. Go to `sites.google.com/view/aoooop/` and make sure that it does not redirect you. 3. Go to `sites.google.com/view/aoooop/aave-com/path` and make sure that you are redirected to the Phishing Warning Page. 4. Click proceed anyway 5. Going to `sites.google.com/view/aoooop/aave-com` should also no longer redirect to the Phishing Warning Page. 6. Going to `sites.google.com/view/aoooop/aave-com/path` should also no longer redirect to the Phishing Warning Page (implicit in step 4). ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Introduce trie-based path matching for phishing detection, add path whitelisting, migrate hotlist diffs to v2, and update tests/mocks and dependencies. > > - **Phishing Detection**: > - **Path-based blocking**: Add `PathTrie` (insert/delete/match, list->trie, deep copy) used to match `hostname+path`. > - **Controller (`PhishingController`)**: new `state.whitelistPaths`; `test`/`bypass` honor path matches; parse stalelist `blocklistPaths` via `convertListToTrie`; hotlist diffs endpoint to `v2`. > - **Detector (`PhishingDetector`)**: check `blocklistPaths` with `matchedPathPrefix`; expose `blockingPath(url)`. > - **Utils**: add `getHostnameAndPathComponents`/`getPathnameFromUrl`; `applyDiffs` supports `blocklistPaths` with trie ops; minor config cleanup. > - **Tests/Mocks**: > - Update E2E/unit tests for path-based logic; add mock pages with nested paths; adjust phishing mocks/schema; expect `diffsSince v2`; metrics masks include `whitelistPaths`. > - **State/Telemetry**: Sanitize/remove `whitelistPaths` from UI state and snapshots. > - **Build & Deps**: > - Patch `@metamask/phishing-controller` (adds new dist files); bump `@metamask/phishing-warning`; lockfile/attributions updates; LavaMoat policies allow `console.error` for base-controller. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5b70d32. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: augmentedmode <[email protected]> [8bdd1e1](8bdd1e1) --------- Co-authored-by: imblue <[email protected]> Co-authored-by: imblue-dabadee <[email protected]> Co-authored-by: MetaMask Bot <[email protected]>
…ons (#36896) - ci: GitHub Actions time usage optimizations (#36629) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> - [Add `concurrency` field to `update-lavamoat-policies`.](a20025f) - Saves approx. 20 minutes of billable time (=runtime of `update-lavamoat-policies`) for each `@metamaskbot update-policies` comment. - Cancels CI run when the comment is posted, instead of waiting for the `update-lavamoat-policies` workflow to complete. - Excluded release branches, where even an incomplete CI run might provide useful info. - Set `timeout-minutes` for all jobs to 30 (instead of default of 360). - Example of 6-hour run: https://github.com/MetaMask/metamask-extension/actions/runs/18155641151/job/51675026463?pr=33539 > All jobs should set [timeout-minutes](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes). > ... > By default, GitHub Actions kills workflows after 6 hours if they have not finished by then. Many workflows don't need nearly as much time to finish, but sometimes unexpected errors occur or a job hangs until the workflow run is killed 6 hours after starting it. Therefore it's recommended to specify a shorter timeout. > ... > This has the following advantages: > > PRs won't be pending CI for half the day, issues can be caught early or workflow runs can be restarted. The number of overall parallel builds is limited, hanging jobs will not cause issues for other PRs if they are cancelled early. > > -- [`ghalint`](https://github.com/suzuki-shunsuke/ghalint/blob/main/docs/policies/012.md#job_timeout_minutes_is_required) [](https://codespaces.new/MetaMask/metamask-extension/pull/36629?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Sets 30-minute timeouts across GitHub Actions jobs and adds concurrency to `update-lavamoat-policies` to cancel superseded runs (excluding `release/*`). > > - **CI/GitHub Actions** > - **Job timeouts**: Add `timeout-minutes: 30` to jobs across workflows (e.g., `main.yml`, tests, builds, e2e, releases, checks) to cap runtime. > - **Concurrency control**: Add `concurrency` to `update-lavamoat-policies.yml` to cancel in-progress runs for the same ref, excluding `release/*` branches. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8169786. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [8453e5e](8453e5e) Co-authored-by: Jongsun Suh <[email protected]>
…release pr template (#36890) - fix(pr template): Use latest version of release pr template (#36743) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The purpose of this PR is to use the latest version of the release PR template. It's a minor change, and it's been tested on this test repo: consensys-test#201 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/36743?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Update `.github/workflows/create-release-pr.yml` to use MetaMask/github-tools workflow and `github-tools-version` at SHA `7fe185fdb0e60981c898e88d82e44ff33f604daa`. > > - **CI/Workflows**: > - Update `create-release-pr.yml` to reference `MetaMask/github-tools/.github/workflows/create-release-pr.yml@7fe185fdb0e60981c898e88d82e44ff33f604daa`. > - Sync `github-tools-version` input to `7fe185fdb0e60981c898e88d82e44ff33f604daa`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0a2922e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [d073679](d073679) Co-authored-by: Gauthier Petetin <[email protected]>
…o use topology.json (#36891) - MCRM-8: Updated add-team-label worklow to use topology.json (#36731) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Ticket: https://consensyssoftware.atlassian.net/browse/MCRM-8 github-tools change: MetaMask/github-tools#137 Testing: consensys-test#200, https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/18387086043 [](https://codespaces.new/MetaMask/metamask-extension/pull/36731?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [220b8c6](220b8c6) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps the `add-team-label` reusable workflow to a newer commit in `metamask/github-tools`. > > - **CI / GitHub Actions**: > - Update reusable workflow reference in `.github/workflows/add-team-label.yml` to `metamask/github-tools/.github/workflows/add-team-label.yml@7fe185f...`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 97bd029. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Pavel Dvorkin <[email protected]> Co-authored-by: Gauthier Petetin <[email protected]>
…#36629)" (#36769) (#36898) - fix: Revert changes from "ci: GitHub Actions time usage optimizations (#36629)" (#36769) This reverts changes from commit 8453e5e. The `concurrency` field added to `update-lavavmoat-policies.yml` is scoped incorrectly, and is blocking workflow runs. <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/36769?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes the workflow-level `concurrency` block from `.github/workflows/update-lavamoat-policies.yml`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 56c20f6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [7846af3](7846af3) Co-authored-by: Jongsun Suh <[email protected]>
release: 13.4.3
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
](https://codespaces.new/MetaMask/metamask-extension/pull/36813?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/36634?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/36629?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/36743?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/36731?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/36769?quickstart=1){kind=link}
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [782e9ce]
UI Startup Metrics (1229 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
chloeYue
approved these changes
Oct 16, 2025
metamaskbot
added
the
release-13.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds 13.4.3 changelog entry (path-based URL blocking) and updates Unreleased/13.4.3 compare links.
CHANGELOG.md):13.4.3with Fixed: path-based URL blocking for URLs (feat: path based blocking cp-13.4.3 cp-13.5.0 #36634).[Unreleased]nowv13.4.3...HEADand add[13.4.3]link.Written by Cursor Bugbot for commit 782e9ce. This will update automatically on new commits. Configure here.