Skip to content

Conversation

@gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Oct 16, 2025

Description

The diff we observe in this stable sync PR comes from these PRs, which were merged to main AFTER the 13.5.0 release cut, but was cherry-picked into 13.4.3:

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds 30-minute timeouts across CI workflows, updates GitHub Tools workflow SHAs, and documents 13.4.3 path-based URL blocking in the changelog.

  • CI/CD:
    • Add timeout-minutes: 30 to jobs across multiple workflows (e.g., main.yml, run-tests.yml, run-e2e.yml, needs-e2e.yml, build-*, publish-*, etc.).
    • Update reusable workflow references to newer SHAs in github-tools (e.g., create-release-pr.yml, add-team-label.yml) and align github-tools-version.
  • Docs:
    • Update CHANGELOG.md with 13.4.3 (Fixed: path-based URL blocking) and adjust compare links.

Written by Cursor Bugbot for commit 8b58d53. This will update automatically on new commits. Configure here.

gauthierpetetin and others added 10 commits October 13, 2025 10:48
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR updates the change log for 13.4.3.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36813?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Updates `CHANGELOG.md` for 13.4.3 with a fix for path-based URL
blocking and refreshes compare links.
> 
> - **Changelog (`CHANGELOG.md`)**:
>   - **13.4.3 (Fixed)**: Add path-based URL blocking entry (#36634).
> - **Links**: Update `[Unreleased]` to compare from `v13.4.3` and add
`[13.4.3]` compare link.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
c6cec8c. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
- feat: path based blocking (#36634)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Introduces URL path based blocking within the extension. This allows
websites like `example.com/path` to be blocked rather than blocking all
of `example.com`.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36634?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Added path-based blocking for URLs

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to `sites.google.com/view/aoooop/aave-com` and make sure that it
you are redirected to the Phishing Warning Page
2. Go to `sites.google.com/view/aoooop/` and make sure that it does not
redirect you.
3. Go to `sites.google.com/view/aoooop/aave-com/path` and make sure that
you are redirected to the Phishing Warning Page.
4. Click proceed anyway
5. Going to `sites.google.com/view/aoooop/aave-com` should also no
longer redirect to the Phishing Warning Page.
6. Going to `sites.google.com/view/aoooop/aave-com/path` should also no
longer redirect to the Phishing Warning Page (implicit in step 4).

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Introduce trie-based path matching for phishing detection, add path
whitelisting, migrate hotlist diffs to v2, and update tests/mocks and
dependencies.
> 
> - **Phishing Detection**:
> - **Path-based blocking**: Add `PathTrie` (insert/delete/match,
list->trie, deep copy) used to match `hostname+path`.
> - **Controller (`PhishingController`)**: new `state.whitelistPaths`;
`test`/`bypass` honor path matches; parse stalelist `blocklistPaths` via
`convertListToTrie`; hotlist diffs endpoint to `v2`.
> - **Detector (`PhishingDetector`)**: check `blocklistPaths` with
`matchedPathPrefix`; expose `blockingPath(url)`.
> - **Utils**: add `getHostnameAndPathComponents`/`getPathnameFromUrl`;
`applyDiffs` supports `blocklistPaths` with trie ops; minor config
cleanup.
> - **Tests/Mocks**:
> - Update E2E/unit tests for path-based logic; add mock pages with
nested paths; adjust phishing mocks/schema; expect `diffsSince v2`;
metrics masks include `whitelistPaths`.
> - **State/Telemetry**: Sanitize/remove `whitelistPaths` from UI state
and snapshots.
> - **Build & Deps**:
> - Patch `@metamask/phishing-controller` (adds new dist files); bump
`@metamask/phishing-warning`; lockfile/attributions updates; LavaMoat
policies allow `console.error` for base-controller.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
5b70d32. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: augmentedmode <[email protected]>
[8bdd1e1](8bdd1e1)

---------

Co-authored-by: imblue <[email protected]>
Co-authored-by: imblue-dabadee <[email protected]>
Co-authored-by: MetaMask Bot <[email protected]>
…ons (#36896)

- ci: GitHub Actions time usage optimizations (#36629)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

- [Add `concurrency` field to

`update-lavamoat-policies`.](a20025f)
- Saves approx. 20 minutes of billable time (=runtime of
`update-lavamoat-policies`) for each `@metamaskbot update-policies`
comment.
- Cancels CI run when the comment is posted, instead of waiting for the
`update-lavamoat-policies` workflow to complete.
- Excluded release branches, where even an incomplete CI run might
provide useful info.

- Set `timeout-minutes` for all jobs to 30 (instead of default of 360).
- Example of 6-hour run:

https://github.com/MetaMask/metamask-extension/actions/runs/18155641151/job/51675026463?pr=33539

> All jobs should set

[timeout-minutes](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes).
> ...
> By default, GitHub Actions kills workflows after 6 hours if they have
not finished by then. Many workflows don't need nearly as much time to
finish, but sometimes unexpected errors occur or a job hangs until the
workflow run is killed 6 hours after starting it. Therefore it's
recommended to specify a shorter timeout.
> ...
> This has the following advantages:
> 
> PRs won't be pending CI for half the day, issues can be caught early
or workflow runs can be restarted. The number of overall parallel builds
is limited, hanging jobs will not cause issues for other PRs if they are
cancelled early.
>
> --

[`ghalint`](https://github.com/suzuki-shunsuke/ghalint/blob/main/docs/policies/012.md#job_timeout_minutes_is_required)

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36629?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Sets 30-minute timeouts across GitHub Actions jobs and adds
concurrency to `update-lavamoat-policies` to cancel superseded runs
(excluding `release/*`).
> 
> - **CI/GitHub Actions**
> - **Job timeouts**: Add `timeout-minutes: 30` to jobs across workflows
(e.g., `main.yml`, tests, builds, e2e, releases, checks) to cap runtime.
> - **Concurrency control**: Add `concurrency` to
`update-lavamoat-policies.yml` to cancel in-progress runs for the same
ref, excluding `release/*` branches.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8169786. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


[8453e5e](8453e5e)

Co-authored-by: Jongsun Suh <[email protected]>
…release pr template (#36890)

- fix(pr template): Use latest version of release pr template (#36743)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The purpose of this PR is to use the latest version of the release PR
template.
It's a minor change, and it's been tested on this test repo:

consensys-test#201

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36743?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Update `.github/workflows/create-release-pr.yml` to use
MetaMask/github-tools workflow and `github-tools-version` at SHA
`7fe185fdb0e60981c898e88d82e44ff33f604daa`.
> 
> - **CI/Workflows**:
> - Update `create-release-pr.yml` to reference
`MetaMask/github-tools/.github/workflows/create-release-pr.yml@7fe185fdb0e60981c898e88d82e44ff33f604daa`.
> - Sync `github-tools-version` input to
`7fe185fdb0e60981c898e88d82e44ff33f604daa`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
0a2922e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


[d073679](d073679)

Co-authored-by: Gauthier Petetin <[email protected]>
…o use topology.json (#36891)

- MCRM-8: Updated add-team-label worklow to use topology.json (#36731)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Ticket: https://consensyssoftware.atlassian.net/browse/MCRM-8
github-tools change: MetaMask/github-tools#137

Testing:

consensys-test#200,

https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/18387086043

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36731?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[220b8c6](220b8c6)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Bumps the `add-team-label` reusable workflow to a newer commit in
`metamask/github-tools`.
> 
> - **CI / GitHub Actions**:
> - Update reusable workflow reference in
`.github/workflows/add-team-label.yml` to
`metamask/github-tools/.github/workflows/add-team-label.yml@7fe185f...`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
97bd029. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Pavel Dvorkin <[email protected]>
Co-authored-by: Gauthier Petetin <[email protected]>
…#36629)" (#36769) (#36898)

- fix: Revert changes from "ci: GitHub Actions time usage optimizations
(#36629)" (#36769)

This reverts changes from commit
8453e5e.

The `concurrency` field added to `update-lavavmoat-policies.yml` is
scoped incorrectly, and is blocking workflow runs.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36769?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Removes the workflow-level `concurrency` block from
`.github/workflows/update-lavamoat-policies.yml`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
56c20f6. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->




[7846af3](7846af3)

Co-authored-by: Jongsun Suh <[email protected]>
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Oct 16, 2025
@gauthierpetetin
Copy link
Contributor Author

@metamaskbot update-attributions

@metamaskbot
Copy link
Collaborator

No attributions changes

@metamaskbot
Copy link
Collaborator

📊 Page Load Benchmark Results

Current Commit: 8b58d53 | Date: 10/16/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±74ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 733ms (±71ms) 🟢 | historical mean value: 734ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)
📈 Detailed Results
Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 74ms 1.01s 1.33s 1.31s 1.33s
domContentLoaded 733ms 71ms 698ms 1.01s 985ms 1.01s
firstPaint 76ms 12ms 64ms 184ms 84ms 184ms
firstContentfulPaint 76ms 12ms 64ms 184ms 84ms 184ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms

Results generated automatically by MetaMask CI

@metamaskbot
Copy link
Collaborator

Builds ready [8b58d53]
UI Startup Metrics (1306 ± 74 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1306115215767413441422
load111296213647311581247
domContentLoaded110595013507311511238
domInteractive19154971835
firstPaint640112138645511221199
backgroundConnect2602473038264275
firstReactRender2917133133347
getState1873572230
initialActions91115131020
loadScripts852708109671897989
setupStore1153231317
WebpackHomeuiStartup19961524257027521372483
load15861212199221717371929
domContentLoaded15761203198321817331922
domInteractive181292151561
firstPaint1696454676188323
backgroundConnect3415348433353
firstReactRender79363256076306
getState3763217815279
initialActions17329050818
loadScripts15721201197221717311919
setupStore2763206315282
FirefoxBrowserifyHomeuiStartup14391218195412114951659
load1228105015018912961372
domContentLoaded1228105015018912961371
domInteractive1063429552114243
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3822140184170
firstReactRender28243323032
getState93598817
initialActions41414412
loadScripts1203103114798712711348
setupStore145209231144
WebpackHomeuiStartup15561389187913216771836
load13181161161512314301553
domContentLoaded13181161161412314291553
domInteractive1083232062112306
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect36236484346
firstReactRender37325033942
getState63232710
initialActions4110246
loadScripts12951133159712514041535
setupStore963751020

@gauthierpetetin gauthierpetetin merged commit fa8ad9f into release/13.5.0 Oct 16, 2025
144 of 145 checks passed
@gauthierpetetin gauthierpetetin deleted the sync-v13.5.0-with-stable-3 branch October 16, 2025 11:43
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2025
@metamaskbot metamaskbot added the release-13.5.0 Issue or pull request that will be included in release 13.5.0 label Oct 16, 2025
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-13.5.0 on PR, as PR was added to branch 13.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

extension-delivery release-13.5.0 Issue or pull request that will be included in release 13.5.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants