fix: in UI implementation of dapp swap feature #37926

jpuri · 2025-11-18T05:21:24Z

Description

Updates in UI implementation of dapp swap feature. UI is not updated when user toggles between swaps.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6275
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6281
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6283

Manual testing steps

Enable dapp-swap locally
Go to test-dapp submit swap
Check switching between swaps is smooth

Screenshots/Recordings

TODO

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds context-managed MetaMask Swap quote selection, updates confirmation to apply quote/approval, and adjusts confirmation UI/alerts accordingly.

Dapp Swap comparison & confirmation flow:
- Introduces context state in confirm (quoteSelectedForMMSwap, isQuotedSwapDisplayedInInfo, setters) and uses it across confirm UI.
- DappSwapComparisonBanner now toggles between current vs MetaMask quote by setting context; shows quote simulation + NetworkRow and removes redux transaction mutations.
- useTransactionConfirm applies selected MM quote to txParams, adds swap approval as batchTransactions, clears nestedTransactions when quote is shown.
- TransactionData decodes from selected quote trade data when present.
Confirm UI adjustments:
- BaseTransactionInfo hides account/details sections when quote view is shown; always renders GasFeesSection/AdvancedDetails.
- EditGasFeesRow and SelectedGasFeeToken hide edit/arrow controls when quote view is shown.
- TransactionDetails always renders Origin/Recipient rows (non-batch); NetworkRow remains; AmountRow logic unchanged.
- BatchSimulationDetails no longer special-cases quoted swaps.
Hooks/metrics:
- Simplifies useSwapCheck (removes isQuotedSwap); latency metric updates made unconditional where applicable.
- useResimulationAlert suppresses alert when quote view is shown; metrics use quote selection to set swap_final_selected.
- useDappSwapComparisonInfo no longer accepts nested tx param; parsing refined.
Tests & fixtures:
- Broad test updates to use new context APIs, expectations, and added mockBridgeQuotes fixture; snapshot headers updated.

^{Written by Cursor Bugbot for commit 7c18d46. This will update automatically on new commits. Configure here.}

…tension into tooltip_fix

github-actions · 2025-11-18T05:21:31Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts

...confirmations/components/confirm/dapp-swap-comparison-banner/dapp-swap-comparison-banner.tsx

ui/pages/confirmations/context/confirm/index.tsx

...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts

metamaskbot · 2025-11-18T19:22:30Z

Builds ready [f730c38]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1235 ± 89 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1235	1086	1495	89	1292	1399
			load	1067	934	1326	82	1119	1215
			domContentLoaded	1060	929	1320	81	1113	1199
			domInteractive	23	14	89	18	19	78
			firstPaint	602	84	1247	433	1083	1208
			backgroundConnect	234	215	281	9	237	244
			firstReactRender	29	19	49	7	30	47
			getState	23	9	53	9	27	45
			initialActions	1	0	4	1	1	2
			loadScripts	832	693	1092	80	883	967
			setupStore	11	7	32	4	12	18
			numNetworkReqs	13	6	76	19	6	70
	Browserify	Power User Home	uiStartup	2109	1923	2748	207	2164	2748
			load	1123	966	1768	224	1350	1768
			domContentLoaded	1104	947	1760	228	1337	1760
			domInteractive	57	17	170	55	127	170
			firstPaint	720	166	1762	512	1013	1762
			backgroundConnect	250	235	277	11	253	277
			firstReactRender	74	51	127	18	81	127
			getState	205	167	321	44	204	321
			initialActions	1	0	2	1	2	2
			loadScripts	875	729	1517	220	1097	1517
			setupStore	25	18	37	5	29	37
			numNetworkReqs	123	94	197	33	145	197
	Webpack	Standard Home	uiStartup	855	737	1233	98	857	1158
			load	625	573	962	88	620	919
			domContentLoaded	617	566	926	83	615	895
			domInteractive	20	12	122	18	15	72
			firstPaint	195	61	933	193	198	755
			backgroundConnect	27	12	79	14	28	62
			firstReactRender	31	20	49	8	37	40
			getState	11	6	43	4	13	16
			initialActions	1	0	4	1	1	1
			loadScripts	614	564	915	81	612	885
			setupStore	12	6	35	4	13	17
			numNetworkReqs	13	6	75	19	8	69
	Webpack	Power User Home	uiStartup	1123	949	1861	249	1302	1861
			load	686	596	932	127	888	932
			domContentLoaded	665	585	881	111	797	881
			domInteractive	38	14	138	42	95	138
			firstPaint	376	70	885	317	803	885
			backgroundConnect	58	10	264	74	71	264
			firstReactRender	43	40	46	2	45	46
			getState	144	97	166	24	160	166
			initialActions	1	1	1	0	1	1
			loadScripts	661	583	871	107	787	871
			setupStore	15	7	31	10	26	31
			numNetworkReqs	84	63	132	25	121	132
Firefox	Browserify	Standard Home	uiStartup	1501	1357	2071	128	1527	1766
			load	1259	1160	1558	83	1291	1459
			domContentLoaded	1259	1159	1557	83	1290	1459
			domInteractive	58	34	268	42	56	151
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	25	209	23	48	90
			firstReactRender	29	23	60	7	29	43
			getState	16	6	198	27	13	33
			initialActions	2	0	3	1	2	2
			loadScripts	1231	1139	1445	76	1269	1415
			setupStore	17	7	216	23	14	37
			numNetworkReqs	12	6	69	16	7	60
	Browserify	Power User Home	uiStartup	3234	2432	4742	631	3950	4742
			load	1541	1359	2185	260	1633	2185
			domContentLoaded	1540	1359	2185	260	1633	2185
			domInteractive	237	96	612	166	349	612
			firstPaint	-	-	-	-	-	-
			backgroundConnect	569	121	1338	454	1093	1338
			firstReactRender	90	64	125	21	111	125
			getState	148	86	197	38	185	197
			initialActions	2	1	3	1	3	3
			loadScripts	1483	1301	2075	240	1570	2075
			setupStore	150	34	522	122	131	522
			numNetworkReqs	125	70	246	63	208	246
	Webpack	Standard Home	uiStartup	1728	1527	2357	159	1729	2098
			load	1448	1285	1818	124	1461	1751
			domContentLoaded	1448	1284	1817	124	1461	1750
			domInteractive	59	31	233	32	65	131
			firstPaint	-	-	-	-	-	-
			backgroundConnect	54	27	190	26	60	121
			firstReactRender	36	27	92	12	36	54
			getState	14	8	192	19	12	18
			initialActions	2	0	3	1	2	3
			loadScripts	1414	1262	1798	114	1429	1683
			setupStore	18	7	74	15	14	56
			numNetworkReqs	13	6	69	18	7	66
	Webpack	Power User Home	uiStartup	3629	2721	5214	729	3963	5214
			load	1837	1514	2309	300	2249	2309
			domContentLoaded	1836	1513	2309	300	2248	2309
			domInteractive	281	101	731	215	535	731
			firstPaint	-	-	-	-	-	-
			backgroundConnect	580	165	1378	383	963	1378
			firstReactRender	91	47	136	21	103	136
			getState	188	108	560	102	214	560
			initialActions	3	1	8	1	3	8
			loadScripts	1781	1481	2241	294	2195	2241
			setupStore	127	40	487	107	119	487
			numNetworkReqs	132	67	245	62	210	245

📊 Page Load Benchmark Results

Current Commit: f730c38 | Date: 11/18/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.06s (±41ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 737ms (±37ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±10ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.06s	41ms	1.03s	1.36s	1.10s	1.36s
domContentLoaded	737ms	37ms	713ms	1.02s	765ms	1.02s
firstPaint	79ms	10ms	64ms	164ms	88ms	164ms
firstContentfulPaint	79ms	10ms	64ms	164ms	88ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

metamaskbot · 2025-11-18T19:55:11Z

Builds ready [f08c704]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1343 ± 95 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1343	1188	1609	95	1399	1528
			load	1150	984	1418	95	1223	1330
			domContentLoaded	1140	961	1414	97	1220	1322
			domInteractive	27	16	99	19	24	83
			firstPaint	710	86	1378	450	1144	1321
			backgroundConnect	261	242	369	21	265	283
			firstReactRender	36	22	174	21	38	58
			getState	27	9	173	19	34	48
			initialActions	1	0	5	1	1	4
			loadScripts	889	710	1167	98	970	1082
			setupStore	13	7	35	5	16	25
			numNetworkReqs	13	6	76	20	6	74
	Browserify	Power User Home	uiStartup	2051	1794	3024	298	2188	3024
			load	1061	888	1847	253	1283	1847
			domContentLoaded	1043	875	1829	254	1274	1829
			domInteractive	55	18	199	56	113	199
			firstPaint	798	203	1870	465	974	1870
			backgroundConnect	198	185	217	8	206	217
			firstReactRender	80	54	126	23	91	126
			getState	212	151	328	49	235	328
			initialActions	1	0	3	1	2	3
			loadScripts	862	700	1626	250	1097	1626
			setupStore	25	13	48	8	33	48
			numNetworkReqs	124	90	205	36	176	205
	Webpack	Standard Home	uiStartup	855	724	1180	86	863	1086
			load	621	565	913	71	617	846
			domContentLoaded	613	560	894	68	612	815
			domInteractive	18	12	81	13	15	54
			firstPaint	174	57	875	144	192	582
			backgroundConnect	27	12	73	13	32	55
			firstReactRender	34	19	231	22	37	41
			getState	11	5	22	3	13	16
			initialActions	1	0	4	1	1	1
			loadScripts	610	558	883	65	610	805
			setupStore	12	6	38	4	14	16
			numNetworkReqs	13	6	74	19	8	70
	Webpack	Power User Home	uiStartup	1133	926	1829	293	1507	1829
			load	698	587	1145	176	901	1145
			domContentLoaded	681	577	1128	169	861	1128
			domInteractive	43	13	190	53	92	190
			firstPaint	351	72	1131	303	580	1131
			backgroundConnect	56	10	252	70	72	252
			firstReactRender	41	38	43	2	43	43
			getState	133	88	155	23	147	155
			initialActions	1	0	1	0	1	1
			loadScripts	677	575	1118	166	851	1118
			setupStore	13	7	26	8	25	26
			numNetworkReqs	83	64	141	29	126	141
Firefox	Browserify	Standard Home	uiStartup	1481	1322	2084	132	1510	1815
			load	1245	1139	1548	83	1292	1401
			domContentLoaded	1245	1139	1547	83	1292	1400
			domInteractive	54	33	183	31	58	137
			firstPaint	-	-	-	-	-	-
			backgroundConnect	43	24	230	26	49	92
			firstReactRender	27	22	53	6	27	41
			getState	14	7	203	22	12	22
			initialActions	1	0	3	1	2	2
			loadScripts	1220	1107	1503	81	1267	1374
			setupStore	16	6	197	27	11	42
			numNetworkReqs	12	6	63	15	8	54
	Browserify	Power User Home	uiStartup	3163	2478	4799	573	3484	4799
			load	1558	1277	2235	274	1643	2235
			domContentLoaded	1558	1276	2235	274	1643	2235
			domInteractive	247	83	655	178	343	655
			firstPaint	-	-	-	-	-	-
			backgroundConnect	489	98	1278	346	764	1278
			firstReactRender	81	63	105	12	90	105
			getState	142	77	205	36	159	205
			initialActions	3	1	8	2	5	8
			loadScripts	1508	1243	2160	274	1596	2160
			setupStore	120	28	427	91	152	427
			numNetworkReqs	125	75	247	65	228	247
	Webpack	Standard Home	uiStartup	1611	1419	2040	127	1625	1947
			load	1375	1219	1724	103	1405	1628
			domContentLoaded	1375	1218	1724	103	1405	1628
			domInteractive	58	30	192	34	63	146
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	24	127	20	52	89
			firstReactRender	33	25	82	9	35	46
			getState	12	7	77	9	11	23
			initialActions	2	1	7	1	2	2
			loadScripts	1347	1199	1638	96	1379	1578
			setupStore	16	5	80	15	13	54
			numNetworkReqs	12	6	68	16	7	63
	Webpack	Power User Home	uiStartup	3624	2719	5112	653	4033	5112
			load	1741	1525	2289	246	2020	2289
			domContentLoaded	1740	1524	2289	246	2020	2289
			domInteractive	237	83	692	208	542	692
			firstPaint	-	-	-	-	-	-
			backgroundConnect	678	80	1423	436	1055	1423
			firstReactRender	103	66	135	19	121	135
			getState	182	112	583	120	157	583
			initialActions	5	2	38	9	3	38
			loadScripts	1687	1456	2220	238	1959	2220
			setupStore	86	36	167	37	122	167
			numNetworkReqs	123	73	225	57	215	225

📊 Page Load Benchmark Results

Current Commit: f08c704 | Date: 11/18/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±40ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 733ms (±36ms) 🟢 | historical mean value: 726ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 78ms (±11ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	40ms	1.01s	1.30s	1.09s	1.30s
domContentLoaded	733ms	36ms	699ms	971ms	769ms	971ms
firstPaint	78ms	11ms	60ms	160ms	92ms	160ms
firstContentfulPaint	78ms	11ms	60ms	160ms	92ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts

metamaskbot · 2025-11-19T04:05:32Z

Builds ready [85df878]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

UI Startup Metrics (1222 ± 95 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1222	1068	1623	95	1267	1403
			load	1060	922	1391	86	1109	1219
			domContentLoaded	1054	919	1384	85	1105	1204
			domInteractive	22	14	86	16	20	72
			firstPaint	600	85	1253	416	1056	1207
			backgroundConnect	233	215	273	9	237	249
			firstReactRender	29	19	65	8	29	47
			getState	20	7	96	10	22	34
			initialActions	1	0	4	1	1	2
			loadScripts	827	697	1157	85	873	980
			setupStore	10	5	21	3	11	15
			numNetworkReqs	13	6	76	19	6	71
	Browserify	Power User Home	uiStartup	2018	1721	2866	290	2091	2866
			load	1068	889	1767	246	1275	1767
			domContentLoaded	1049	874	1738	246	1265	1738
			domInteractive	54	18	147	46	119	147
			firstPaint	648	207	1271	339	941	1271
			backgroundConnect	211	187	256	16	216	256
			firstReactRender	71	50	94	11	75	94
			getState	198	148	288	40	237	288
			initialActions	1	0	5	1	2	5
			loadScripts	860	686	1537	243	1087	1537
			setupStore	26	13	52	13	35	52
			numNetworkReqs	128	94	198	34	160	198
	Webpack	Standard Home	uiStartup	794	666	1221	100	793	1072
			load	569	518	949	83	562	830
			domContentLoaded	562	511	929	80	555	810
			domInteractive	18	11	92	13	16	50
			firstPaint	204	52	932	210	171	732
			backgroundConnect	26	10	70	13	28	54
			firstReactRender	32	19	233	22	35	41
			getState	10	5	21	3	12	16
			initialActions	1	0	1	0	1	1
			loadScripts	559	509	922	79	553	800
			setupStore	11	5	38	5	13	16
			numNetworkReqs	14	6	78	20	8	72
	Webpack	Power User Home	uiStartup	1065	894	1686	245	1245	1686
			load	678	561	1086	181	852	1086
			domContentLoaded	660	550	1042	167	818	1042
			domInteractive	46	13	239	64	84	239
			firstPaint	381	68	1087	356	619	1087
			backgroundConnect	44	10	261	60	66	261
			firstReactRender	39	37	42	1	40	42
			getState	132	87	171	24	144	171
			initialActions	1	0	1	0	1	1
			loadScripts	656	548	1032	163	807	1032
			setupStore	11	6	26	7	10	26
			numNetworkReqs	80	61	140	25	110	140
Firefox	Browserify	Standard Home	uiStartup	1493	1330	2003	131	1521	1800
			load	1254	1137	1567	89	1268	1455
			domContentLoaded	1254	1136	1567	89	1267	1455
			domInteractive	53	35	227	37	49	152
			firstPaint	-	-	-	-	-	-
			backgroundConnect	41	25	102	15	50	78
			firstReactRender	28	23	43	4	28	41
			getState	12	7	51	6	11	24
			initialActions	2	1	3	1	2	2
			loadScripts	1230	1117	1540	86	1245	1425
			setupStore	14	7	92	11	14	28
			numNetworkReqs	12	6	63	15	7	54
	Browserify	Power User Home	uiStartup	3124	2427	4151	452	3388	4151
			load	1529	1280	2135	270	1706	2135
			domContentLoaded	1528	1280	2135	270	1706	2135
			domInteractive	222	57	573	161	370	573
			firstPaint	-	-	-	-	-	-
			backgroundConnect	533	87	1077	319	862	1077
			firstReactRender	77	49	106	14	85	106
			getState	132	65	194	38	172	194
			initialActions	2	2	4	1	3	4
			loadScripts	1473	1230	2024	253	1632	2024
			setupStore	84	29	158	36	107	158
			numNetworkReqs	128	81	239	61	219	239
	Webpack	Standard Home	uiStartup	1653	1424	2044	145	1711	1974
			load	1393	1230	1729	114	1439	1644
			domContentLoaded	1393	1230	1729	114	1439	1644
			domInteractive	56	30	183	29	64	120
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	23	139	22	54	107
			firstReactRender	35	26	83	11	37	63
			getState	13	8	52	8	12	25
			initialActions	1	0	3	1	2	2
			loadScripts	1362	1190	1702	106	1416	1569
			setupStore	18	7	110	19	14	68
			numNetworkReqs	13	6	68	17	8	66
	Webpack	Power User Home	uiStartup	3511	2730	4624	589	4202	4624
			load	1707	1469	2098	195	1879	2098
			domContentLoaded	1706	1468	2098	194	1878	2098
			domInteractive	226	96	558	153	395	558
			firstPaint	-	-	-	-	-	-
			backgroundConnect	533	139	1163	336	798	1163
			firstReactRender	100	66	157	26	129	157
			getState	236	113	615	146	212	615
			initialActions	2	2	3	0	3	3
			loadScripts	1647	1427	1946	180	1838	1946
			setupStore	88	44	140	31	123	140
			numNetworkReqs	130	77	232	55	190	232

📊 Page Load Benchmark Results

Current Commit: 85df878 | Date: 11/18/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±38ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 720ms (±36ms) 🟢 | historical mean value: 722ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	38ms	1.01s	1.32s	1.06s	1.32s
domContentLoaded	720ms	36ms	697ms	991ms	742ms	991ms
firstPaint	77ms	11ms	64ms	168ms	88ms	168ms
firstContentfulPaint	77ms	11ms	64ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

The base branch was changed.

...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts

chaitanyapotti

lgtm for web3auth related changes

metamaskbot · 2025-11-19T09:19:41Z

Builds ready [7c18d46]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
- content-script: 0
- offscreen: 0

📊 Page Load Benchmark Results

Current Commit: 7c18d46 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±37ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 710ms (±35ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 74ms (±10ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	37ms	999ms	1.30s	1.04s	1.30s
domContentLoaded	710ms	35ms	691ms	979ms	730ms	979ms
firstPaint	74ms	10ms	56ms	156ms	84ms	156ms
firstContentfulPaint	74ms	10ms	56ms	156ms	84ms	156ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 53 Bytes (0%)
ui: -116 Bytes (0%)
common: 20 Bytes (0%)

jpuri added 17 commits November 14, 2025 22:26

Fix: backup/restore for batched swaps

986f169

update

f75740a

Merge branch 'main' into dapp_switch_fix

60ed1c4

update

bb5b33e

feat: additing more dapp swap metrics

3551fc4

update

82a4107

Make min amount dynamic value in tooltip

7050926

Merge branch 'main' into tooltip_fix

3381053

update

7f2cfc5

Merge branch 'tooltip_fix' of https://github.com/MetaMask/metamask-ex…

4cb1711

…tension into tooltip_fix

update

e40396c

merge

0c9e63c

Update on dapp-swap ui

d7850f2

update

57c4bcd

update

64fd8fe

Merge branch 'main' into dapp_switch_fix

8c021cf

Merge branch 'dapp_switch_fix' into dapp_swap_metrics

fde6444

jpuri added 3 commits November 18, 2025 10:56

update

ad034f3

Updating test cases

af809b3

Adding test coverage

9308918

jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Nov 18, 2025

jpuri marked this pull request as ready for review November 18, 2025 08:44

jpuri requested a review from a team as a code owner November 18, 2025 08:44

jpuri changed the title ~~UI fix~~ fix: fix in UI implementation of dapp swap feature Nov 18, 2025

cursor bot reviewed Nov 18, 2025

View reviewed changes

...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts Show resolved Hide resolved

update

7d645d4

cursor bot reviewed Nov 18, 2025

View reviewed changes

...confirmations/components/confirm/dapp-swap-comparison-banner/dapp-swap-comparison-banner.tsx Show resolved Hide resolved

ui/pages/confirmations/context/confirm/index.tsx Show resolved Hide resolved

update

e394827

cursor bot reviewed Nov 18, 2025

View reviewed changes

...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts Show resolved Hide resolved

jpuri added 2 commits November 19, 2025 00:09

update

ae5d03d

update

f730c38

update

f08c704

update

a391830

jpuri requested a review from a team as a code owner November 18, 2025 20:04

update

6df8f91

cursor bot reviewed Nov 18, 2025

View reviewed changes

update

85df878

OGPoyraz previously approved these changes Nov 19, 2025

View reviewed changes

Base automatically changed from dapp_swap_metrics to main November 19, 2025 08:29

merge

fc1a9b9

cursor bot reviewed Nov 19, 2025

View reviewed changes

...confirmations/hooks/transactions/dapp-swap-comparison/useDappSwapComparisonLatencyMetrics.ts Show resolved Hide resolved

jpuri enabled auto-merge November 19, 2025 08:51

jpuri requested a review from OGPoyraz November 19, 2025 08:51

jpuri changed the title ~~fix: fix in UI implementation of dapp swap feature~~ fix: in UI implementation of dapp swap feature Nov 19, 2025

Merge branch 'main' into ui_fix

7c18d46

OGPoyraz approved these changes Nov 19, 2025

View reviewed changes

chaitanyapotti approved these changes Nov 19, 2025

View reviewed changes

jpuri added this pull request to the merge queue Nov 19, 2025

Merged via the queue into main with commit b4e970f Nov 19, 2025
162 of 174 checks passed

jpuri deleted the ui_fix branch November 19, 2025 09:58

github-actions bot locked and limited conversation to collaborators Nov 19, 2025

metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 19, 2025

fix: in UI implementation of dapp swap feature #37926

fix: in UI implementation of dapp swap feature #37926

Conversation

jpuri commented Nov 18, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 18, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

metamaskbot commented Nov 18, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

chaitanyapotti left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Nov 19, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jpuri commented Nov 18, 2025 •

edited by cursor bot

Loading