Skip to content

Conversation

@lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented Nov 18, 2025

Description

Fixed extra scroll on claims form. There is a hidden input field inside the component with sr-only tailwind class. this element needs relative parent so it will not be placed on unexpected location

https://consensyssoftware.atlassian.net/browse/SUBS-761

Open in GitHub Codespaces

Changelog

CHANGELOG entry: fixed extra scroll on claims-form

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

image

After

Screen.Recording.2025-11-18.at.4.52.25.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds relative to the FileUploader drop area container class to adjust positioning.

Written by Cursor Bugbot for commit c19b9a5. This will update automatically on new commits. Configure here.

@lionellbriones lionellbriones requested a review from a team as a code owner November 18, 2025 08:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-web3auth Web3Auth team label Nov 18, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🎨 @MetaMask/design-system-engineers (1 files, +1 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 component-library/
        • 📁 file-uploader/
          • 📄 file-uploader.tsx +1 -1

@metamaskbot
Copy link
Collaborator

Builds ready [1006e0b]
UI Startup Metrics (1222 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12221063160210112911375
load106491813639111311201
domContentLoaded105891213509011261192
domInteractive221496161871
firstPaint58890136543110561188
backgroundConnect2302172557234247
firstReactRender27184552839
getState2195882634
initialActions103112
loadScripts834669111290905966
setupStore1062831116
numNetworkReqs1367419670
BrowserifyPower User HomeuiStartup21781758326831922623268
load1134984146819514031468
domContentLoaded1112967143118913641431
domInteractive611718357115183
firstPaint66911714414059961441
backgroundConnect25122831820253318
firstReactRender79471342795134
getState23717133046281330
initialActions206126
loadScripts882741120818411231208
setupStore30224053540
numNetworkReqs1187217428153174
WebpackStandard HomeuiStartup774654110388784973
load55150887069552728
domContentLoaded54450085565545711
domInteractive161172121447
firstPaint19154858198159715
backgroundConnect251078133157
firstReactRender3119122143550
getState1153851218
initialActions105111
loadScripts54149584764543704
setupStore1153851219
numNetworkReqs1467620875
WebpackPower User HomeuiStartup1087911183727814091837
load660571956134818956
domContentLoaded644562914122774914
domInteractive33131053482105
firstPaint37271958318778958
backgroundConnect571018868160188
firstReactRender40365034250
getState1399415622154156
initialActions102112
loadScripts640560903119760903
setupStore1362582425
numNetworkReqs836313828128138
FirefoxBrowserifyStandard HomeuiStartup15451350226014715911908
load1296116415719813751510
domContentLoaded1296116415699813751510
domInteractive59352234056164
firstPaint------
backgroundConnect47262432951115
firstReactRender29246282955
getState138204201119
initialActions203122
loadScripts1266114715069413271443
setupStore158219231227
numNetworkReqs1266615858
BrowserifyPower User HomeuiStartup31882536421750735834217
load15481323202222118162022
domContentLoaded15481322202222118162022
domInteractive25073619185473619
firstPaint------
backgroundConnect582141128036510511280
firstReactRender885413124113131
getState1499928944170289
initialActions213123
loadScripts14991261199823017761998
setupStore12236449100160449
numNetworkReqs1267724459208244
WebpackStandard HomeuiStartup16281447230616016542094
load13751196177812214141655
domContentLoaded13751196177812214141655
domInteractive55281592762120
firstPaint------
backgroundConnect49172533354117
firstReactRender352587133776
getState147141161150
initialActions213122
loadScripts13461180169710813851592
setupStore15779131247
numNetworkReqs1366817762
WebpackPower User HomeuiStartup33822526440057536634400
load16921455208521119042085
domContentLoaded16921455208521119042085
domInteractive22676548153356548
firstPaint------
backgroundConnect522144970296857970
firstReactRender986013522118135
getState17611125938192259
initialActions317137
loadScripts16371417202819518412028
setupStore15034595178161595
numNetworkReqs1267023257183232
📊 Page Load Benchmark Results

Current Commit: 1006e0b | Date: 11/18/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 718ms (±36ms) 🟢 | historical mean value: 730ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 39ms 1.01s 1.32s 1.06s 1.32s
domContentLoaded 718ms 36ms 696ms 984ms 738ms 984ms
firstPaint 75ms 10ms 60ms 156ms 88ms 156ms
firstContentfulPaint 75ms 10ms 60ms 156ms 88ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 9 Bytes (0%)
  • common: 20 Bytes (0%)

@metamaskbot
Copy link
Collaborator

Builds ready [c19b9a5]
UI Startup Metrics (1137 ± 95 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup113797814469511901294
load97782612688710321109
domContentLoaded97081912438510251097
domInteractive211475131861
firstPaint659145127538410071078
backgroundConnect18717225612191211
firstReactRender25185362540
getState1954682337
initialActions102112
loadScripts790644105084846917
setupStore1041821114
numNetworkReqs1367520672
BrowserifyPower User HomeuiStartup20831833265221222642652
load1130968163020213511630
domContentLoaded1111953162020713401620
domInteractive511713945124139
firstPaint593138140838810021408
backgroundConnect24823327110255271
firstReactRender725299179199
getState21517330336247303
initialActions107117
loadScripts883726138620611171386
setupStore29155193651
numNetworkReqs1208618832155188
WebpackStandard HomeuiStartup85872012861158611178
load6275641041102612935
domContentLoaded620558102497605912
domInteractive181176131553
firstPaint226611027244202920
backgroundConnect271381153260
firstReactRender3219131133649
getState1163851221
initialActions104111
loadScripts617556101394603902
setupStore1164251318
numNetworkReqs1367519871
WebpackPower User HomeuiStartup1091936156822213481568
load662571998122763998
domContentLoaded646561955113726955
domInteractive33131073275107
firstPaint31375958260573958
backgroundConnect55102206681220
firstReactRender42364634546
getState1399417125153171
initialActions101011
loadScripts642559945110716945
setupStore15629102729
numNetworkReqs846213026123130
FirefoxBrowserifyStandard HomeuiStartup14801317204612615121767
load1248113014828412911449
domContentLoaded1248113014818412911447
domInteractive54331723360146
firstPaint------
backgroundConnect4124120184490
firstReactRender26224852736
getState157203231140
initialActions208122
loadScripts1223110914558012621423
setupStore147130151237
numNetworkReqs1266715759
BrowserifyPower User HomeuiStartup37692808522870343165228
load17601441269341020562693
domContentLoaded17601440269341020562693
domInteractive29477921281543921
firstPaint------
backgroundConnect851132145036011911450
firstReactRender945914825118148
getState15811723134173231
initialActions615613456
loadScripts16961365256739920222567
setupStore10326447100120447
numNetworkReqs1167024057145240
WebpackStandard HomeuiStartup16151378222714716291981
load13751200169711014091657
domContentLoaded13741199169611014091657
domInteractive58302013463146
firstPaint------
backgroundConnect47251452451113
firstReactRender322490103342
getState1175271122
initialActions103123
loadScripts13441183164710213641610
setupStore15785161261
numNetworkReqs1367517765
WebpackPower User HomeuiStartup33352579440364540854403
load17121445219324520082193
domContentLoaded17121444219324520082193
domInteractive25690685191418685
firstPaint------
backgroundConnect53310811253548031125
firstReactRender84481172098117
getState16711921430191214
initialActions317147
loadScripts16601409207923518992079
setupStore1002541989100419
numNetworkReqs1256924060199240
📊 Page Load Benchmark Results

Current Commit: c19b9a5 | Date: 11/19/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 716ms (±37ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 76ms (±14ms) 🟢 | historical mean value: 77ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 39ms 1.01s 1.32s 1.06s 1.32s
domContentLoaded 716ms 37ms 697ms 989ms 737ms 989ms
firstPaint 76ms 14ms 60ms 204ms 84ms 204ms
firstContentfulPaint 76ms 14ms 60ms 204ms 84ms 204ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 9 Bytes (0%)
  • common: 20 Bytes (0%)

@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue Nov 19, 2025
@lionellbriones lionellbriones added the team-design-system All issues relating to design system in Extension label Nov 19, 2025
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Nov 19, 2025
@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Nov 19, 2025
Merged via the queue into main with commit 766009f Nov 19, 2025
195 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/fix-claims-form-extra-scroll branch November 19, 2025 11:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@metamaskbot metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.11.0 Issue or pull request that will be included in release 13.11.0 size-XS team-design-system All issues relating to design system in Extension team-web3auth Web3Auth team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants