Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Resolve a known issue with gas included swaps that require a token approval #13584

Open
dan437 opened this issue Feb 18, 2025 · 0 comments · May be fixed by #13639
Open

[Bug]: Resolve a known issue with gas included swaps that require a token approval #13584

dan437 opened this issue Feb 18, 2025 · 0 comments · May be fixed by #13639
Labels
regression-RC-7.41.0 Regression bug that was found in release candidate (RC) for release 7.41.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-transactions Transactions team type-bug Something isn't working

Comments

@dan437
Copy link
Contributor

dan437 commented Feb 18, 2025

Describe the bug

When a token approval is needed for gas included swaps, only the approval works, but not the swap transaction.

Related PR: #13430

Expected behavior

When a token approval is needed for gas included swaps, both the approval and swap transactions will work.

Screenshots/Recordings

No response

Steps to reproduce

When a token approval is needed for gas included swaps, only the approval works, but not the swap transaction.

Error messages or log output

Detection stage

During release testing

Version

7.41.0

Build type

None

Device

iPhone

Operating system

iOS

Additional context

No response

Severity

No response

@dan437 dan437 added regression-RC-7.41.0 Regression bug that was found in release candidate (RC) for release 7.41.0 release-blocker This bug is blocking the next release team-transactions Transactions team type-bug Something isn't working labels Feb 18, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Feb 18, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 18, 2025
@jvbriones jvbriones added the Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing label Feb 18, 2025
@dan437 dan437 linked a pull request Feb 20, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-RC-7.41.0 Regression bug that was found in release candidate (RC) for release 7.41.0 release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing team-transactions Transactions team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be fixed
Development

Successfully merging a pull request may close this issue.

2 participants