fix: cp-7.41.0 Temporarily revert gas included swaps

[dan437]

Description

Reverts #13430 for now.

We initially believed that resolving the known issue with gas-included swaps requiring token approval would be easy and could be completed before the release candidate for version 7.41.0 was pushed to production, but it turns out that more fundamental changes are needed. Specifically, submitBatch support from the TransactionController—allowing the simultaneous submission of multiple transactions (approval and swap)—is required. This submitBatch support will likely also be used for current swaps that need token approval to increase success rates.

EDIT: there is an alternative short-term solution that the Swaps team is working on to fix approval + swap on mobile. Once that one is merged, this code should work.

Related issues

Fixes: #13584

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a99b1a3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e072a905-cac3-4c08-beee-da930d0913c4

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.72%. Comparing base (07d05d7) to head (30b922a).

Files with missing lines	Patch %	Lines
app/components/UI/Swaps/QuotesView.js	16.66%	5 Missing ⚠️
app/core/Engine/Engine.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13639   +/-   ##
=======================================
  Coverage   62.72%   62.72%           
=======================================
  Files        2025     2025           
  Lines       44474    44431   -43     
  Branches     6044     6041    -3     
=======================================
- Hits        27897    27871   -26     
+ Misses      14736    14719   -17     
  Partials     1841     1841           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[httpJunkie]

revert of changes from #13430, checked against that PR and everything looks good.

[sonarqubecloud]

Quality Gate failed

Failed conditions
41.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud