Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support standalone confirmation for re-redesigned confirmations #13550
base: main
Are you sure you want to change the base?
feat: Support standalone confirmation for re-redesigned confirmations #13550
Changes from all commits
11fe037
64a59a6
8902416
9fb7532
b58b19f
72c80f0
3f7c96f
3c27fe7
0106769
f6eba09
fbf6468
70151a2
c5ba6d5
9ea208f
d8bcaf9
514c523
65f59d2
ca93177
307ab9b
d42e716
ceaf463
0768be2
916f452
a00e484
51084ca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not
StandaloneConfirmation
be same asFlatConfirmation
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because
FlatConfirmation
is a confirmation with fullscreen that's all.One example of
FlatConfirmation
will beSendFlow
, where it will have it's ownStack.Navigator
andStack.Screens
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In summary;
ModalConfirmations
=> for usingSignatures
, all otherTransaction
types etcFlatConfirmation
=> A confirmation where it needs to be a full flow, has it's own navigator insideStandaloneConfirmation
=> Where we can put a confirmation anywhere in the app (In anyStack
)I think these covering all the use cases we have it in mobile today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I think we need only 2 types of styling, which essentially is point of classification here - modal and full screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not remove the test case till code is there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to use
useFlatConfirmation
here.