Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement staking advanced details #13551

Merged
merged 6 commits into from
Feb 19, 2025
Merged

feat: Implement staking advanced details #13551

merged 6 commits into from
Feb 19, 2025
+457 −20

Conversation

pedronfigueiredo
Copy link
Contributor

Description

Implements expandable InfoSectionAccordion component that expands and collapses on press and has a text header. Leverages this new component to implement the advanced details section.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4082

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

advanced-details.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Feb 17, 2025
@pedronfigueiredo pedronfigueiredo self-assigned this Feb 17, 2025
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners February 17, 2025 10:34
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a7001a8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c34aff1e-849b-4fce-92b9-59e4adee2376

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

jpuri
jpuri previously approved these changes Feb 17, 2025
View reviewed changes
@pedronfigueiredo pedronfigueiredo added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 17, 2025
@pedronfigueiredo pedronfigueiredo added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a7677af
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3c45c48a-9939-4ada-aa9a-d3b48b1c6b2a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@pedronfigueiredo pedronfigueiredo added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d24fc39
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/666eec89-213e-45ef-9d6f-0747499e7fa1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@pedronfigueiredo pedronfigueiredo added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ca00d2d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/35f7e3be-6c6b-4da1-ac71-ae29ad03d8b1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

jpuri
jpuri previously approved these changes Feb 18, 2025
View reviewed changes
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@pedronfigueiredo pedronfigueiredo removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 19, 2025
@pedronfigueiredo pedronfigueiredo added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 3af7ce9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33e550bb-3bf8-4cb1-bf07-90c0c683b558

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@pedronfigueiredo pedronfigueiredo added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f159b99
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a7b26bae-85a4-446e-b7a1-b7794b738172

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@pedronfigueiredo pedronfigueiredo added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 302ed83
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd45781b-3879-483e-ab03-9bec9b9d2424

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@pedronfigueiredo pedronfigueiredo added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 19, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pedronfigueiredo pedronfigueiredo added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 19, 2025
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 797ecbd Feb 19, 2025
49 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/4082 branch February 19, 2025 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@jpuri jpuri jpuri left review comments

Assignees

@pedronfigueiredo pedronfigueiredo

Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pedronfigueiredo @jpuri @OGPoyraz @metamaskbot