Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-7.41.0 Redesigned confirmation pages - reduce height of scrollable section for android #13571

Closed
wants to merge 2 commits into from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 18, 2025

Description

Redesigned confirmation pages - reduce height of scrollable section for android

Related issues

Fixes: #13516

Manual testing steps

  1. Run test dapp on android emulator / device
  2. Check height of footer buttons - they should be clearly visible

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner February 18, 2025 08:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 18, 2025
@@ -11,6 +11,7 @@ const styleSheet = (params: {
theme,
vars: { isFlatConfirmation },
} = params;
const modalScrollWrapperHeight = Device.isIos() ? '75%' : '70%';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OGPoyraz value 70% may need to be adjusted to ensure that buttons are correctly positioned in android.

@jpuri jpuri added the DO-NOT-MERGE Pull requests that should not be merged label Feb 18, 2025
@sethkfman sethkfman changed the title fix: Redesigned confirmation pages - reduce height of scrollable section for android fix: cp-7.41.0 Redesigned confirmation pages - reduce height of scrollable section for android Feb 18, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
72.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@jpuri jpuri closed this Feb 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO-NOT-MERGE Pull requests that should not be merged team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Reject and Confirm buttons on redesigned Signatures are not fully visible when using larger font size
4 participants