Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adding e2e for confirmation page scroll button #13575

Merged
merged 9 commits into from
Feb 20, 2025
Merged

chore: Adding e2e for confirmation page scroll button #13575

merged 9 commits into from
Feb 20, 2025
+110 −3

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 18, 2025 •
edited
Loading

Description

Adding e2e for confirmation page scroll button

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4218

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 18, 2025
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 18, 2025
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 18, 2025
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 18, 2025
@MetaMask MetaMask deleted a comment from github-actions bot Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 02ad66b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d983d3ee-2a1f-47c9-adc4-0c85c751ffc1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@MetaMask MetaMask deleted a comment from github-actions bot Feb 18, 2025
@MetaMask MetaMask deleted a comment from github-actions bot Feb 18, 2025
cortisiko
cortisiko requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpuri thanks for creating an e2e test! I left a few comments!

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1636e9d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1f9eb36c-0581-4b5e-bb72-9f95d4cf5148

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cortisiko
cortisiko previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@jpuri jpuri marked this pull request as ready for review February 18, 2025 23:52
@jpuri jpuri requested review from a team as code owners February 18, 2025 23:52
@jpuri jpuri enabled auto-merge February 18, 2025 23:54
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ab92fc6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/52fa9bcd-a5c0-48fd-b08c-6fb1fa52d530

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri requested review from digiwand and cortisiko February 20, 2025 11:08
@jpuri jpuri added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit cb68f81 Feb 20, 2025
43 of 45 checks passed
@jpuri jpuri deleted the scroll_e2e branch February 20, 2025 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@cortisiko cortisiko Awaiting requested review from cortisiko

Assignees
No one assigned
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpuri @cortisiko @digiwand @metamaskbot