Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: native gas token bridge tx submission #13577

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bfullam
Copy link
Contributor

@bfullam bfullam commented Feb 18, 2025

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bfullam bfullam added team-swaps Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-identity labels Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2581322
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b38ee34-fb6b-4ace-8c83-427a8e5c79b2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@bfullam bfullam changed the title Mms 1889 native gas token bridge tx submission feat: native gas token bridge tx submission Feb 18, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 62.62%. Comparing base (b5ea162) to head (d7f66d1).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
app/components/UI/Bridge/hooks/useHandleTx.ts 0.00% 18 Missing ⚠️
...pp/components/UI/Bridge/hooks/useHandleBridgeTx.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13577      +/-   ##
==========================================
+ Coverage   62.53%   62.62%   +0.08%     
==========================================
  Files        2005     2016      +11     
  Lines       44261    44376     +115     
  Branches     6006     6028      +22     
==========================================
+ Hits        27679    27789     +110     
- Misses      14748    14751       +3     
- Partials     1834     1836       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants