Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EarnTokenSelector component for stablecoin lending #13595

Merged
merged 8 commits into from
Feb 19, 2025

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Feb 18, 2025

Description

This PR introduces a new EarnTokenSelector component to enhance the Input screen for stablecoin lending. The component provides a more intuitive way to select and view earning opportunities, displaying token information, APR, and balance in a unified interface.

This PR also adds the token selector on the Input screen behind the stablecoin feature flag.

Related issues

Fixes: STAKE-899

Manual testing steps

  1. Turn on the stablecoin lending feature flag in .js.env
  2. Click on earn button in the wallet actions
  3. Select a token
  4. You should be redirected to the input screen with a new token selector component
  5. Select any other token from token selector and you should see the details for that token

Screenshots/Recordings

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-02-19.at.01.56.36.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 189e633
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e5cf154d-5561-4d4b-a80b-91727dfb369e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 47561de
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/254caac6-db07-4b54-ace5-513cb1b62fd0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@amitabh94 amitabh94 marked this pull request as ready for review February 19, 2025 08:04
@amitabh94 amitabh94 requested a review from a team as a code owner February 19, 2025 08:04
@amitabh94 amitabh94 enabled auto-merge February 19, 2025 08:05
@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 19, 2025
Copy link
Contributor

github-actions bot commented Feb 19, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f1a548e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dd68b4ca-04c6-4c6d-a90e-8c58c162db44

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Matt561
Matt561 previously approved these changes Feb 19, 2025
Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please hold off on merging this until after #13594 has been merged. It's a release blocker and I think this may conflict with it since there are changes to the StakeInputView.


Update: #13594 has been merged into main.

Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitabh94 amitabh94 added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 0a30188 Feb 19, 2025
39 checks passed
@amitabh94 amitabh94 deleted the STAKE-899--fe-add-earn-token-selector branch February 19, 2025 22:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants