Skip to content

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Sep 15, 2025

Description

upgrade network enablement controllers to fit with BIP-44

Changelog

CHANGELOG entry: upgrade network enablement controller

Related issues

Fixes: #19746

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb marked this pull request as ready for review September 15, 2025 09:14
@salimtb salimtb requested a review from a team as a code owner September 15, 2025 09:14
cursor[bot]

This comment was marked as outdated.

Copy link

socket-security bot commented Sep 15, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​utils@​11.7.0 ⏵ 11.8.099 +110094 +198 +2100
Updatednpm/​@​metamask/​network-enablement-controller@​0.6.0 ⏵ 1.1.099 +1100100 +197 +1100

View full report

@salimtb salimtb requested a review from a team as a code owner September 15, 2025 09:43
@github-actions github-actions bot added size-M and removed size-S labels Sep 15, 2025
cursor[bot]

This comment was marked as outdated.

@salimtb salimtb added the Run Smoke E2E Requires smoke E2E testing label Sep 15, 2025
@salimtb salimtb requested a review from a team as a code owner September 15, 2025 14:57
@salimtb salimtb marked this pull request as draft September 15, 2025 15:20
@salimtb salimtb added run-ios-e2e-smoke Trigger iOS E2E tests on BitRise and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 16, 2025
Copy link
Contributor

github-actions bot commented Sep 16, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4aee33a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d355256a-5fb7-42b0-8c95-9af851d4d65a

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb added run-ios-e2e-smoke Trigger iOS E2E tests on BitRise and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 16, 2025
Copy link
Contributor

github-actions bot commented Sep 16, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b4f3460
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93c15740-6793-464a-bc1f-cb8e34881316

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.48%. Comparing base (3562734) to head (b4f3460).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...hooks/useNetworkEnablement/useNetworkEnablement.ts 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19734   +/-   ##
=======================================
  Coverage   76.47%   76.48%           
=======================================
  Files        3274     3275    +1     
  Lines       78928    78961   +33     
  Branches    14291    14299    +8     
=======================================
+ Hits        60364    60395   +31     
- Misses      14632    14636    +4     
+ Partials     3932     3930    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salimtb salimtb enabled auto-merge September 16, 2025 11:25
@salimtb
Copy link
Contributor Author

salimtb commented Sep 16, 2025

Broken e2e tests are not related to this PR as they also fail on another PRs, example here

@salimtb salimtb added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed No E2E Smoke Needed If the PR does not need E2E smoke test run labels Sep 16, 2025
@salimtb salimtb added run-ios-e2e-smoke Trigger iOS E2E tests on BitRise and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 16, 2025
Copy link
Contributor

github-actions bot commented Sep 16, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ce207e2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dfa4f72a-1e22-4e10-a2a7-c876fb3589d0

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the run-ios-e2e-smoke label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

@salimtb salimtb added skip-e2e skip E2E test jobs and removed run-ios-e2e-smoke Trigger iOS E2E tests on BitRise labels Sep 16, 2025
@salimtb salimtb added this pull request to the merge queue Sep 16, 2025
Merged via the queue into main with commit 1532eb0 Sep 16, 2025
106 of 109 checks passed
@salimtb salimtb deleted the fix/fix-network-enablement branch September 16, 2025 12:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2025
@metamaskbot metamaskbot added release-7.57.0 Issue or pull request that will be included in release 7.57.0 release-7.56.0 Issue or pull request that will be included in release 7.56.0 and removed release-7.57.0 Issue or pull request that will be included in release 7.57.0 labels Sep 16, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.56.0 on PR. Adding release label release-7.56.0 on PR and removing other release labels(release-7.57.0), as PR was cherry-picked in branch 7.56.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.56.0 Issue or pull request that will be included in release 7.56.0 size-XL skip-e2e skip E2E test jobs team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Network filter always shows all networks as the label
5 participants