-
Notifications
You must be signed in to change notification settings - Fork 585
Add requireScroll
prop to Footer
component
#3031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3031 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 507 507
Lines 11185 11185
Branches 1722 1722
=======================================
Hits 10619 10619
Misses 566 566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
requireCompleteView
prop to Footer
componentrequireScroll
prop to Footer
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we don't merge this until we have a working extension branch linked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can you add (or update an existing) example Snap so we can E2E test this?
|
Adds a new prop to require that snap ui content be viewed entirely before enabling the footer button(s).
Note: This is the snaps side code for #3021, a follow up PR to integrate in the extension will be opened.