Skip to content

Add requireScroll prop to Footer component #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

hmalik88
Copy link
Contributor

Adds a new prop to require that snap ui content be viewed entirely before enabling the footer button(s).

Note: This is the snaps side code for #3021, a follow up PR to integrate in the extension will be opened.

@hmalik88 hmalik88 marked this pull request as ready for review January 22, 2025 21:55
@hmalik88 hmalik88 requested a review from a team as a code owner January 22, 2025 21:55
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.93%. Comparing base (61853b0) to head (38ff1d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3031   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         507      507           
  Lines       11185    11185           
  Branches     1722     1722           
=======================================
  Hits        10619    10619           
  Misses        566      566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmalik88 hmalik88 changed the title Add requireCompleteView prop to Footer component Add requireScroll prop to Footer component Jan 22, 2025
GuillaumeRx
GuillaumeRx previously approved these changes Jan 23, 2025
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we don't merge this until we have a working extension branch linked

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add (or update an existing) example Snap so we can E2E test this?

@hmalik88
Copy link
Contributor Author

Looks good, but can you add (or update an existing) example Snap so we can E2E test this?

#3173

@hmalik88 hmalik88 requested a review from Mrtenz March 11, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants