Get cancellation policies by reservations operation #650
+117
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VBuben
reviewed
Sep 16, 2024
operations/cancellationpolicies.md
Outdated
Comment on lines
116
to
118
| ## Get cancellation policies by reservations | ||
|
|
||
| Gets cancellation policies for enterprise grouped by reservation for granular cancellation policies flow. This operation supports [Portfolio Access Tokens](../guidelines/multi-property.md). |
There was a problem hiding this comment.
@Filip-Macecek @DenysShylov I think we should slap Restricted over the endpoint? 🤔 It can be done via [Restricted] annotation in the controller.
There was a problem hiding this comment.
will add this attribute to the code. also added restricted description here
operations/cancellationpolicies.md
Outdated
| | `ClientToken` | string | required | Token identifying the client application. | | ||
| | `AccessToken` | string | required | Access token of the client application. | | ||
| | `Client` | string | required | Name and version of the client application. | | ||
| | `ReservationIds` | array of string | optional, max 100 items | List of reservation identifiers. | |
There was a problem hiding this comment.
Suggested change
| | `ReservationIds` | array of string | optional, max 100 items | List of reservation identifiers. | | |
| | `ReservationIds` | array of string | required, max 100 items | List of reservation identifiers. | |
I think this one is required right?
There was a problem hiding this comment.
you are right, missed this attribute in parameters, fix already in the PR)
MikeAdamsMews
approved these changes
Sep 20, 2024
| | :-- | :-- | :-- | :-- | | ||
| | `CancellationPolicies` | array of [Cancellation policy data grouped by reservation.](cancellationpolicies.md#cancellation-policy-data-grouped-by-reservation) | required, max 1300 items | List of cancellation policies data grouped by reservation. | | ||
|
|
||
| #### Cancellation policy data grouped by reservation. |
There was a problem hiding this comment.
Suggested change
| #### Cancellation policy data grouped by reservation. | |
| #### Cancellation policy data grouped by reservation |
|
|
||
| | Property | Type | Contract | Description | | ||
| | :-- | :-- | :-- | :-- | | ||
| | `CancellationPolicies` | array of [Cancellation policy data grouped by reservation.](cancellationpolicies.md#cancellation-policy-data-grouped-by-reservation) | required, max 1300 items | List of cancellation policies data grouped by reservation. | |
There was a problem hiding this comment.
Suggested change
| | `CancellationPolicies` | array of [Cancellation policy data grouped by reservation.](cancellationpolicies.md#cancellation-policy-data-grouped-by-reservation) | required, max 1300 items | List of cancellation policies data grouped by reservation. | | |
| | `CancellationPolicies` | array of [Cancellation policy data grouped by reservation](cancellationpolicies.md#cancellation-policy-data-grouped-by-reservation) | required, max 1300 items | List of cancellation policies data grouped by reservation. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New operation documentation: Get cancellation policies by reservations operation.
Follow style guide
Style guide
Check during review